Sign upLogin

d3yii2/yii2-d3acc

View on GitHub
Star
components/PeriodBase.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method close has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function close(int $periodType, int $sysCompanyId): AcPeriod
    {

        if (!$lastPeriod = AcPeriod::find()
            ->where([
Severity: Minor
Found in components/PeriodBase.php - About 1 hr to fix

    Method addNewPeriod has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function addNewPeriod(int $periodType, int $sysCompanyId): AcPeriod
    {
        if (!$lastPeriod = AcPeriod::find()
            ->where([
                'sys_company_id' => $sysCompanyId,
    Severity: Minor
    Found in components/PeriodBase.php - About 1 hr to fix

      Function close has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function close(int $periodType, int $sysCompanyId): AcPeriod
    {

        if (!$lastPeriod = AcPeriod::find()
            ->where([
      Severity: Minor
      Found in components/PeriodBase.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status