Sign upLogin

d4l3k/WebSync

View on GitHub
Star
assets/lib/MTL.js

Summary

Maintainability
F
4 days
Test Coverage

Function parse has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    parse: function(data, mtllibCallback) {

        function vector(x, y, z) {

            return new THREE.Vector3(x, y, z);
Severity: Minor
Found in assets/lib/MTL.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has 158 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    parse: function(data, mtllibCallback) {

        function vector(x, y, z) {

            return new THREE.Vector3(x, y, z);
Severity: Major
Found in assets/lib/MTL.js - About 6 hrs to fix

    File MTL.js has 397 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Loads a Wavefront .mtl file specifying materials
 *
 * @author angelxuanchang
 */
    Severity: Minor
    Found in assets/lib/MTL.js - About 5 hrs to fix

      Function convert has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

          convert: function(materialsInfo) {

        if (!this.options) return materialsInfo;

        var converted = {};
      Severity: Minor
      Found in assets/lib/MTL.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parse has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          parse: function(text) {

        var lines = text.split("\n");
        var info = {};
        var delimiter_pattern = /\s+/;
      Severity: Minor
      Found in assets/lib/MTL.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createMaterial_ has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          createMaterial_: function(materialName) {

        // Create material

        var mat = this.materialsInfo[materialName];
      Severity: Minor
      Found in assets/lib/MTL.js - About 1 hr to fix

        Function convert has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            convert: function(materialsInfo) {

        if (!this.options) return materialsInfo;

        var converted = {};
        Severity: Minor
        Found in assets/lib/MTL.js - About 1 hr to fix

          Function parse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              parse: function(text) {

        var lines = text.split("\n");
        var info = {};
        var delimiter_pattern = /\s+/;
          Severity: Minor
          Found in assets/lib/MTL.js - About 1 hr to fix

            Function createMaterial_ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                createMaterial_: function(materialName) {

        // Create material

        var mat = this.materialsInfo[materialName];
            Severity: Minor
            Found in assets/lib/MTL.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                        if (value[0] === 0 && value[1] === 0 && value[1] === 0) {

                                // ignore

                                save = false;
            Severity: Major
            Found in assets/lib/MTL.js - About 45 mins to fix

              Function load has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  load: function(url, mtlurl, onLoad, onProgress, onError) {
              Severity: Minor
              Found in assets/lib/MTL.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                THREE.MTLLoader = function(baseUrl, options, crossOrigin) {

    this.baseUrl = baseUrl;
    this.options = options;
    this.crossOrigin = crossOrigin;
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 50 mins to fix
                assets/lib/mathquill.js on lines 272..276

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else if ((result = normal_pattern.exec(line)) !== null) {

                // ["vn 1.0 2.0 3.0", "1.0", "2.0", "3.0"]

                normals.push(vector(
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 35 mins to fix
                assets/lib/MTL.js on lines 672..779

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else if ((result = vertex_pattern.exec(line)) !== null) {

                // ["v 1.0 2.0 3.0", "1.0", "2.0", "3.0"]

                vertices.push(vector(
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 35 mins to fix
                assets/lib/MTL.js on lines 682..779

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.side = (this.options && this.options.side) ? this.options.side : THREE.FrontSide;
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 30 mins to fix
                assets/lib/MTL.js on lines 126..126

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.wrap = (this.options && this.options.wrap) ? this.options.wrap : THREE.RepeatWrapping;
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 30 mins to fix
                assets/lib/MTL.js on lines 125..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                } else {

                    add_face(faces[0], faces[1], faces[3]);
                    add_face(faces[1], faces[2], faces[3]);
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 30 mins to fix
                assets/lib/MTL.js on lines 617..622

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (!(uvs === undefined) && uvs.length > 0) {

                    add_uvs(uvs[0], uvs[1], uvs[3]);
                    add_uvs(uvs[1], uvs[2], uvs[3]);
                Severity: Minor
                Found in assets/lib/MTL.js and 1 other location - About 30 mins to fix
                assets/lib/MTL.js on lines 610..615

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status