Sign upLogin

dLobatog/npm2rpm

View on GitHub
Star

Showing 5 of 6 total issues

Function generateSpecFile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateSpecFile(npm_module, files, dependencies, release, template_name, scl) {
  for (binary in npm_module.bin) {
    npm_module.bin[binary] = npm_module.bin[binary].replace(/^\.\//, '');
  }
Severity: Minor
Found in lib/spec_file_generator.js - About 1 hr to fix

    Function dependenciesToRequires has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function dependenciesToRequires(deps, scl) {
  var dependencies = [];
  var sortedDeps = sortedDeps = sorted(deps);
  var sclPrefix = '';
    Severity: Minor
    Found in lib/spec_file_generator.js - About 1 hr to fix

      Function writeSpecFile has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function writeSpecFile(npmModule, files, dependencies, release, template, specDir, scl) {
      Severity: Major
      Found in bin/npm2rpm.js - About 50 mins to fix

        Function generateSpecFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function generateSpecFile(npm_module, files, dependencies, release, template_name, scl) {
        Severity: Minor
        Found in lib/spec_file_generator.js - About 45 mins to fix

          Function dependenciesToRequires has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function dependenciesToRequires(deps, scl) {
  var dependencies = [];
  var sortedDeps = sortedDeps = sorted(deps);
  var sclPrefix = '';
          Severity: Minor
          Found in lib/spec_file_generator.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language