Sign upLogin

dadeg/php-crowdflower

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public function update()
  {
    if ($this->getJobId() === null) { throw new Exception('job_id'); }
    if ($this->getId() === null) { throw new Exception('judgment_id'); }
    if ($this->getAttributesChanged() === null) { throw new Exception('judgment_attributes'); }
Severity: Major
Found in src/CrowdFlower/Judgment.php and 1 other location - About 3 hrs to fix
src/CrowdFlower/Unit.php on lines 64..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public function update()
  {
    if ($this->getJobId() === null) { throw new Exception('job_id'); }
    if ($this->getId() === null) { throw new Exception('unit_id'); }
    if ($this->getAttributesChanged() === null) { throw new Exception('unit_attributes'); }
Severity: Major
Found in src/CrowdFlower/Unit.php and 1 other location - About 3 hrs to fix
src/CrowdFlower/Judgment.php on lines 88..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Job has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class Job extends Base
{
  protected $objectType = 'job';
  protected $units = array();
  protected $judgments = array();
Severity: Minor
Found in src/CrowdFlower/Job.php - About 2 hrs to fix

    Function serializeAttributes has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      protected function serializeAttributes($parameters)
  {
    $parametersStr = "";
    $i = 0;
    foreach ($parameters as $k => $v) {
    Severity: Minor
    Found in src/CrowdFlower/Base.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setChannels has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      public function setChannels($data)
  {
    if ($this->getId() === null) { throw new Exception('job_id'); }
    if (is_string($data)) {
      $parametersStr = 'channels[]=' . urlencode($data);
    Severity: Minor
    Found in src/CrowdFlower/Job.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      protected function sendRequest($method, $urlModifier, $data = null)
  {
    $result = $this->request->send($method, $urlModifier, $data);
    $result = json_decode($result);
    Severity: Minor
    Found in src/CrowdFlower/Base.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function __construct($message, $code = 0, Exception $previous = null) {
      // premade messages

      switch ($message) {
        case 'job_attributes':
    Severity: Minor
    Found in src/CrowdFlower/Exception.php - About 1 hr to fix

      Function create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        public function create($count = 0, $channels = Array("on_demand"))
  {
    if ($this->getJobId() === null) { throw new CrowdFlowerException('job_id'); }

    $url = "jobs/" . $this->getJobId() . "/orders.json?";
      Severity: Minor
      Found in src/CrowdFlower/Order.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        public function __construct($message, $code = 0, Exception $previous = null) {
      // premade messages

      switch ($message) {
        case 'job_attributes':
      Severity: Minor
      Found in src/CrowdFlower/Exception.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public function delete()
  {
    if ($this->getJobId() === null) { throw new Exception('job_id'); }
    if ($this->getId() === null) { throw new Exception('unit_id'); }
      Severity: Major
      Found in src/CrowdFlower/Unit.php and 2 other locations - About 45 mins to fix
      src/CrowdFlower/Judgment.php on lines 103..111
      src/CrowdFlower/Unit.php on lines 88..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public function cancel()
  {
    if ($this->getJobId() === null) { throw new Exception('job_id'); }
    if ($this->getId() === null) { throw new Exception('unit_id'); }
      Severity: Major
      Found in src/CrowdFlower/Unit.php and 2 other locations - About 45 mins to fix
      src/CrowdFlower/Judgment.php on lines 103..111
      src/CrowdFlower/Unit.php on lines 78..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public function delete()
  {
    if ($this->getJobId() === null) { throw new Exception('job_id'); }
    if ($this->getId() === null) { throw new Exception('judgment_id'); }
      Severity: Major
      Found in src/CrowdFlower/Judgment.php and 2 other locations - About 45 mins to fix
      src/CrowdFlower/Unit.php on lines 78..86
      src/CrowdFlower/Unit.php on lines 88..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        public function __construct(Request $request, $jobId, $unitId = null, $id = null, $attributes = array())
      Severity: Minor
      Found in src/CrowdFlower/Judgment.php - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language