Sign upLogin

daikon-cqrs/money-interop

View on GitHub
Star

Showing 3 of 3 total issues

Money has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Money implements MoneyInterface
{
    protected ?PhpMoney $money;

    /** @param static $comparator */
Severity: Minor
Found in src/ValueObject/Money.php - About 2 hrs to fix

    Method validate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function validate($input): MoneyInterface
    {
        Assertion::string($input, 'Must be a string.');

        $settings = $this->getSettings();
    Severity: Minor
    Found in src/Validator/MoneyValidator.php - About 1 hr to fix

      Function buildFormatters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildFormatters(Injector $injector, array $formatterConfigs = []): AggregateMoneyFormatter
    {
        $formatters = [];
        foreach ($formatterConfigs as $formatterConfig) {
            if (is_array($formatterConfig['currencies'])) {
      Severity: Minor
      Found in src/Service/MoneyServiceProvisioner.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language