Sign upLogin

dalexhd/SteamSpeak

View on GitHub
Star
packages/server/src/core/Website/api/controllers/auth.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function send has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const send = async function (req: Request, res: Response): Promise<any> {
    log.info(`Received send request to ${req.body.dbid} from remote.`, { type: 'website' });
    try {
        const [client] = await findClients(
            req,
Severity: Minor
Found in packages/server/src/core/Website/api/controllers/auth.ts - About 1 hr to fix

    Function login has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const login = async function (req: Request, res: Response): Promise<any> {
    log.info(`Received login request from ${req.body.dbid}.`, { type: 'website' });
    try {
        const [client] = await findClients(
            req,
    Severity: Minor
    Found in packages/server/src/core/Website/api/controllers/auth.ts - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
        const decoded = jwt.verify(req.token, config.jwt.secret) as { uid: string };
        const client = (await Ts3.getClientByUid(decoded.uid)) as TeamSpeakClient;
        const accessToken = createToken(client.uniqueIdentifier);
        return res.status(200).json({
      Severity: Major
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 4 other locations - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/auth.ts on lines 69..83
      packages/server/src/core/Website/api/controllers/auth.ts on lines 95..126
      packages/server/src/core/Website/api/controllers/auth.ts on lines 138..170
      packages/server/src/core/Website/api/controllers/auth.ts on lines 181..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
        const clients = await findClients(
            req,
            {
                clientType: 0
      Severity: Major
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 4 other locations - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/auth.ts on lines 95..126
      packages/server/src/core/Website/api/controllers/auth.ts on lines 138..170
      packages/server/src/core/Website/api/controllers/auth.ts on lines 181..190
      packages/server/src/core/Website/api/controllers/auth.ts on lines 201..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
        const decoded = jwt.verify(req.token, config.jwt.secret) as { uid: string };
        const client = await Ts3.getClientByUid(decoded.uid);
        return res.status(200).json({ userData: client });
    } catch (error) {
      Severity: Major
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 4 other locations - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/auth.ts on lines 69..83
      packages/server/src/core/Website/api/controllers/auth.ts on lines 95..126
      packages/server/src/core/Website/api/controllers/auth.ts on lines 138..170
      packages/server/src/core/Website/api/controllers/auth.ts on lines 201..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      Cache.set(
                    `${client.databaseId}:token`,
                    JSON.stringify({
                        ip: client.connectionClientIp,
                        token
      Severity: Minor
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 1 other location - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/verify.ts on lines 72..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
        const [client] = await findClients(
            req,
            {
                clientType: 0,
      Severity: Major
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 4 other locations - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/auth.ts on lines 69..83
      packages/server/src/core/Website/api/controllers/auth.ts on lines 95..126
      packages/server/src/core/Website/api/controllers/auth.ts on lines 181..190
      packages/server/src/core/Website/api/controllers/auth.ts on lines 201..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          try {
        const [client] = await findClients(
            req,
            {
                clientType: 0,
      Severity: Major
      Found in packages/server/src/core/Website/api/controllers/auth.ts and 4 other locations - About 45 mins to fix
      packages/server/src/core/Website/api/controllers/auth.ts on lines 69..83
      packages/server/src/core/Website/api/controllers/auth.ts on lines 138..170
      packages/server/src/core/Website/api/controllers/auth.ts on lines 181..190
      packages/server/src/core/Website/api/controllers/auth.ts on lines 201..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status