Sign upLogin

damianopetrungaro/CachetSDK

View on GitHub
Star

Showing 20 of 20 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * This file is part of the CachetSDK package.
 *
 * @author  Damiano Petrungaro  <damianopetrungaro@gmail.com>
Severity: Major
Found in src/Incidents/IncidentActions.php and 2 other locations - About 2 days to fix
src/Groups/GroupActions.php on lines 1..201
src/Metrics/MetricActions.php on lines 1..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 526.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * This file is part of the CachetSDK package.
 *
 * @author  Damiano Petrungaro  <damianopetrungaro@gmail.com>
Severity: Major
Found in src/Groups/GroupActions.php and 2 other locations - About 2 days to fix
src/Incidents/IncidentActions.php on lines 1..201
src/Metrics/MetricActions.php on lines 1..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 526.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * This file is part of the CachetSDK package.
 *
 * @author  Damiano Petrungaro  <damianopetrungaro@gmail.com>
Severity: Major
Found in src/Metrics/MetricActions.php and 2 other locations - About 2 days to fix
src/Groups/GroupActions.php on lines 1..201
src/Incidents/IncidentActions.php on lines 1..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 526.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method searchPoints has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function searchPoints($metricId, $search, $by, $limit = 1, $num = 1000, $page = 1)
Severity: Minor
Found in src/Points/PointActions.php - About 45 mins to fix

    Method searchIncidents has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function searchIncidents($search, $by, $limit = 1, $num = 1000, $page = 1)
    Severity: Minor
    Found in src/Incidents/IncidentActions.php - About 35 mins to fix

      Method searchMetrics has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function searchMetrics($search, $by, $limit = 1, $num = 1000, $page = 1)
      Severity: Minor
      Found in src/Metrics/MetricActions.php - About 35 mins to fix

        Method searchSubscribers has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function searchSubscribers($search, $by, $limit = 1, $num = 1000, $page = 1)
        Severity: Minor
        Found in src/Subscribers/SubscriberActions.php - About 35 mins to fix

          Method searchComponents has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function searchComponents($search, $by, $limit = 1, $num = 1000, $page = 1)
          Severity: Minor
          Found in src/Components/ComponentActions.php - About 35 mins to fix

            Method searchGroups has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function searchGroups($search, $by, $limit = 1, $num = 1000, $page = 1)
            Severity: Minor
            Found in src/Groups/GroupActions.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                      return array_slice($filtered, 0, $limit);
              Severity: Major
              Found in src/Metrics/MetricActions.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return array_slice($filtered, 0, $limit);
                Severity: Major
                Found in src/Components/ComponentActions.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return array_slice($filtered, 0, $limit);
                  Severity: Major
                  Found in src/Incidents/IncidentActions.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return array_slice($filtered, 0, $limit);
                    Severity: Major
                    Found in src/Groups/GroupActions.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return array_slice($filtered, 0, $limit);
                      Severity: Major
                      Found in src/Points/PointActions.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return array_slice($filtered, 0, $limit);
                        Severity: Major
                        Found in src/Subscribers/SubscriberActions.php - About 30 mins to fix

                          Function call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function call($method, $endpoint, array $params = [])
    {
        try {
            $request = new Request($method, $endpoint, ['http_errors' => false]);
            $response = $this->client->send($request, $params);
                          Severity: Minor
                          Found in src/CachetClient.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Line exceeds 120 characters; contains 133 characters
                          Open

                              public function __construct(RequestInterface $request, $message, \Exception $previous = null, ResponseInterface $response = null)
                          Severity: Minor
                          Found in src/Exceptions/Exception.php by phpcodesniffer

                          Line exceeds 120 characters; contains 146 characters
                          Open

                                  parent::__construct($request, 'The data format received is invalid. "data" key is missing from the response array', $previous, $response);
                          Severity: Minor
                          Found in src/Exceptions/InvalidResponseException.php by phpcodesniffer

                          Line exceeds 120 characters; contains 126 characters
                          Open

                              public function __construct(RequestInterface $request, $message, \Exception $previous = null, ResponseInterface $response)
                          Severity: Minor
                          Found in src/Exceptions/ClientException.php by phpcodesniffer

                          Line exceeds 120 characters; contains 128 characters
                          Open

                                      throw new CachetTooManyRedirectsException($e->getRequest(), $e->getMessage(), $e->getPrevious(), $e->getResponse());
                          Severity: Minor
                          Found in src/CachetClient.php by phpcodesniffer
                          Severity
                          Category
                          Status
                          Source
                          Language