Sign upLogin

damianopetrungaro/clean-architecture

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testAddDataMethod($fakeInitialArray, $value, $expectedValue)
    {
        // Create a mock for data and error
        $dataCollection = $this->prophesize(Collection::class);
        $dataCollection->get('key', [])->shouldBeCalledTimes(1)->willReturn($fakeInitialArray);
Severity: Major
Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 2 hrs to fix
tests/Unit/UseCase/Response/ResponseTest.php on lines 85..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testAddErrorMethod($fakeInitialArray, $value, $expectedValue)
    {
        // Create a mock for data and error
        $errorCollection = $this->prophesize(Collection::class);
        $errorCollection->get('key', [])->shouldBeCalledTimes(1)->willReturn($fakeInitialArray);
Severity: Major
Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 2 hrs to fix
tests/Unit/UseCase/Response/ResponseTest.php on lines 62..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

CollectionTest has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class CollectionTest extends TestCase
{
    /**
     * Check that the items passed in the constructor is correctly assigned
     *
Severity: Minor
Found in tests/Unit/Common/Collection/CollectionTest.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testReplaceErrorMethod($value)
    {
        // Create a mock for data and error
        $errorCollection = $this->prophesize(Collection::class);
        $errorCollection->with('key', $value)->shouldBeCalledTimes(1);
    Severity: Minor
    Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 1 hr to fix
    tests/Unit/UseCase/Response/ResponseTest.php on lines 19..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testReplaceDataMethod($value)
    {
        // Create a mock for data and error
        $dataCollection = $this->prophesize(Collection::class);
        $dataCollection->with('key', $value)->shouldBeCalledTimes(1);
    Severity: Minor
    Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 1 hr to fix
    tests/Unit/UseCase/Response/ResponseTest.php on lines 40..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testGetDataAndGetErrors(array $expected, array $actual)
    {
        // Create a mock for data and error
        $collectionProphecy = $this->prophesize(Collection::class);
        $collectionProphecy->all()->willReturn($expected);
    Severity: Minor
    Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 50 mins to fix
    tests/Unit/UseCase/Response/ResponseTest.php on lines 127..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testHasDataAndHasErrorsMethodAreEquals($expected, $actual)
    {
        // Create a mock for data and error
        $collectionProphecy = $this->prophesize(Collection::class);
        $collectionProphecy->length()->willReturn($expected);
    Severity: Minor
    Found in tests/Unit/UseCase/Response/ResponseTest.php and 1 other location - About 50 mins to fix
    tests/Unit/UseCase/Response/ResponseTest.php on lines 107..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language