Sign upLogin

danielpclark/CardsLib

View on GitHub
Star

Showing 3 of 3 total issues

Method inject_while? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def inject_while?(m)
        result, *array = dup
        loop do
          break if array.empty?
          other = array.shift
Severity: Minor
Found in lib/cards_lib/refinements.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method face_from_rank_and_suit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def face_from_rank_and_suit(rank, suit)
      if rank && suit
        [rank, ((rank.length.>(1) && suit.length.>(1)) ? " of " : ""), suit].join
      else
        raise InvalidRankAndSuit, "Suit and Rank provided in Hash are invalid!"
Severity: Minor
Found in lib/cards_lib/card.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

%w-literals should be delimited by [ and ].
Open

            cards.sort.map(&:rank) == Cards[*%w(As Ks Qs Js Ts)].sort.map(&:rank)
Severity: Minor
Found in lib/cards_lib/standard/rules/poker_rule.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)
Severity
Category
Status
Source
Language