Sign upLogin

danielweinmann/unlock_gateway

View on GitHub
Star

Showing 2 of 2 total issues

Method transition_state has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def transition_state(state)
      authorize @contribution
      @initiative = @contribution.initiative
      @user = @contribution.user
      state = state.to_sym
Severity: Minor
Found in lib/unlock_gateway/controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transition_state has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def transition_state(state)
      authorize @contribution
      @initiative = @contribution.initiative
      @user = @contribution.user
      state = state.to_sym
Severity: Minor
Found in lib/unlock_gateway/controller.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language