danini-the-panini/mittsu-opengl

View on GitHub

Showing 67 of 251 total issues

Method set_program has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def set_program(camera, lights, fog, material, object)
Severity: Minor
Found in lib/mittsu/opengl/renderer.rb - About 35 mins to fix

    Method render_objects has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def render_objects(render_list, camera, lights, fog, override_material)
    Severity: Minor
    Found in lib/mittsu/opengl/renderer.rb - About 35 mins to fix

      Method set_polygon_offset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def set_polygon_offset(polygon_offset, factor, units)
            if @current_polygon_offset != polygon_offset
              if polygon_offset
                GL.Enable(GL::POLYGON_OFFSET_FILL)
              else
      Severity: Minor
      Found in lib/mittsu/opengl/state.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def render(scene, camera, render_target = default_target, force_clear = false)
            raise "ERROR: Mittsu::OpenGL::Renderer#render: camera is not an instance of Mittsu::Camera" unless camera.is_a?(Camera)
      
            reset_cache_for_this_frame
      
      
      Severity: Minor
      Found in lib/mittsu/opengl/renderer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render_buffer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
            type = GL::UNSIGNED_INT # geometry_group.type_array == Uint32Array ? GL::UNSIGNED_INT : GL::UNSIGNED_SHORT
      
            # wireframe
            if material.wireframe
      Severity: Minor
      Found in lib/mittsu/opengl_implementation/objects/mesh.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method project_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def project_object(scene, object, shadow_camera)
            if object.visible
              opengl_objects = @opengl_objects[object.id]
      
              if opengl_objects && object.cast_shadow && (object.frustum_culled == false || @frustum.intersects_object?(object) == true)
      Severity: Minor
      Found in lib/mittsu/opengl/plugins/shadow_map_plugin.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call_debug_method has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def call_debug_method m, called_from = caller[0], *args
            if m.to_s.start_with?('Uniform')
              uniform_name = @@current_shader.get_uniform_name(args.first)
              call = "#{m}('#{uniform_name}',#{args[1..-1].map { |s| s.to_s[0..20] }.join(', ')})"
            else
      Severity: Minor
      Found in lib/mittsu/opengl/gl_debug.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language