danini-the-panini/mittsu

View on GitHub
lib/mittsu/objects/mesh.rb

Summary

Maintainability
D
2 days
Test Coverage
F
12%

Method has too many lines. [139/30]
Open

    def raycast(raycaster, intersects)
      @_inverse_matrix ||= Matrix4.new
      @_ray ||= Ray.new
      @_sphere ||= Sphere.new

Severity: Minor
Found in lib/mittsu/objects/mesh.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method raycast has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
Open

    def raycast(raycaster, intersects)
      @_inverse_matrix ||= Matrix4.new
      @_ray ||= Ray.new
      @_sphere ||= Sphere.new

Severity: Minor
Found in lib/mittsu/objects/mesh.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method raycast has 139 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def raycast(raycaster, intersects)
      @_inverse_matrix ||= Matrix4.new
      @_ray ||= Ray.new
      @_sphere ||= Sphere.new

Severity: Major
Found in lib/mittsu/objects/mesh.rb - About 5 hrs to fix

    Cyclomatic complexity for raycast is too high. [28/6]
    Open

        def raycast(raycaster, intersects)
          @_inverse_matrix ||= Matrix4.new
          @_ray ||= Ray.new
          @_sphere ||= Sphere.new
    
    
    Severity: Minor
    Found in lib/mittsu/objects/mesh.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method check_intersection has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def check_intersection object, raycaster, ray, pA, pB, pC, point
    Severity: Major
    Found in lib/mittsu/objects/mesh.rb - About 50 mins to fix

      Avoid parameter lists longer than 5 parameters. [7/5]
      Open

          def check_intersection object, raycaster, ray, pA, pB, pC, point
      Severity: Minor
      Found in lib/mittsu/objects/mesh.rb by rubocop

      This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

      Method check_intersection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_intersection object, raycaster, ray, pA, pB, pC, point
      
            intersect = nil;
            material = object.material;
      
      
      Severity: Minor
      Found in lib/mittsu/objects/mesh.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method definitions must not be nested. Use lambda instead.
      Open

              def morph_target_index_by_name(name)
                morph_target_index = @morph_targets_dictionary[name]
                return morph_target_index unless morph_target_index.nil?
      
                puts "WARNING: Mittsu::Mest#morph_target_index_by_name: morph target #{name} does not exist. Returning 0."
      Severity: Minor
      Found in lib/mittsu/objects/mesh.rb by rubocop

      This cop checks for nested method definitions.

      Example:

      # bad
      
      # `bar` definition actually produces methods in the same scope
      # as the outer `foo` method. Furthermore, the `bar` method
      # will be redefined every time `foo` is invoked.
      def foo
        def bar
        end
      end

      Example:

      # good
      
      def foo
        bar = -> { puts 'hello' }
        bar.call
      end

      Example:

      # good
      
      def foo
        self.class_eval do
          def bar
          end
        end
      end
      
      def foo
        self.module_exec do
          def bar
          end
        end
      end

      Example:

      # good
      
      def foo
        class << self
          def bar
          end
        end
      end

      There are no issues that match your filters.

      Category
      Status