dappros/ethora

View on GitHub
client-reactnative/src/helpers/chat/createMessageObject.ts

Summary

Maintainability
D
1 day
Test Coverage

Function createMessageObject has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const createMessageObject = (messageDetails = []) => {
  const message: IMessage = {
    _id: '',
    text: '',
    createdAt: '',
Severity: Major
Found in client-reactnative/src/helpers/chat/createMessageObject.ts - About 4 hrs to fix

Consider simplifying this complex logical expression.
Open

    if (item.name === 'data') {
      message.user.name =
        item.attrs.senderFirstName + ' ' + item.attrs.senderLastName;
      message.user._id = item.attrs.senderJID;
      const isSystem = item.attrs.isSystemMessage === 'true';
Severity: Critical
Found in client-reactnative/src/helpers/chat/createMessageObject.ts - About 3 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          const mainMessage: IMainMessage = {
            text: parsedMessage.text || '',
            id: parsedMessage?.id,
            userName: parsedMessage.userName || '',
            createdAt: parsedMessage.createdAt,
Severity: Major
Found in client-reactnative/src/helpers/chat/createMessageObject.ts and 1 other location - About 7 hrs to fix
client-web/src/utils/createMessage.ts on lines 43..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 192.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Missing radix parameter
Open

      message.createdAt = new Date(parseInt(item.attrs.id.substring(0, 13))).toDateString();

Rule: radix

Requires the radix parameter to be specified when calling parseInt.

Rationale

From MDN:

Always specify this parameter to eliminate reader confusion and to guarantee predictable behavior. Different implementations produce different results when a radix is not specified, usually defaulting the value to 10.

Config

Not configurable.

Examples
"radix": true

For more information see this page.

" should be '
Open

import { IMessage } from "../../stores/chatStore";

Rule: quotemark

Enforces quote character for string literals.

Notes
  • Has Fix

Config

Five arguments may be optionally provided:

  • "single" enforces single quotes.
  • "double" enforces double quotes.
  • "backtick" enforces backticks.
  • "jsx-single" enforces single quotes for JSX attributes.
  • "jsx-double" enforces double quotes for JSX attributes.
  • "avoid-template" forbids single-line untagged template strings that do not contain string interpolations. Note that backticks may still be used if "avoid-escape" is enabled and both single and double quotes are present in the string (the latter option takes precedence).
  • "avoid-escape" allows you to use the "other" quotemark in cases where escaping would normally be required. For example, [true, "double", "avoid-escape"] would not report a failure on the string literal 'Hello "World"'.
Examples
"quotemark": true,single,avoid-escape,avoid-template
"quotemark": true,single,jsx-double
Schema
{
  "type": "array",
  "items": {
    "type": "string",
    "enum": [
      "single",
      "double",
      "backtick",
      "jsx-single",
      "jsx-double",
      "avoid-escape",
      "avoid-template"
    ]
  },
  "minLength": 0,
  "maxLength": 5
}

For more information see this page.

There are no issues that match your filters.

Category
Status