Sign upLogin

dappros/ethora

View on GitHub
Star
client-reactnative/src/stores/accountStore.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function deleteEmailFromList has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async deleteEmailFromList(token: any, email: any) {
    const url = addOrDeleteEmail + '/' + email;

    runInAction(() => {
      this.isFetching = true;
Severity: Minor
Found in client-reactnative/src/stores/accountStore.ts - About 1 hr to fix

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    try {
      const res = await httpGet(url, token);
      this.isFetching = false;
      if (res.data.success) {
        runInAction(() => {
Severity: Major
Found in client-reactnative/src/stores/accountStore.ts and 3 other locations - About 1 hr to fix
client-reactnative/src/stores/loginStore.ts on lines 213..234
client-reactnative/src/stores/loginStore.ts on lines 457..480
client-reactnative/src/stores/loginStore.ts on lines 493..505

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      if (res.data.success) {
        this.getEmailList(token);
        showToast('success', 'Success', 'Email deleted successfully', 'top');
      } else {
        runInAction(() => {
Severity: Minor
Found in client-reactnative/src/stores/accountStore.ts and 2 other locations - About 35 mins to fix
client-reactnative/src/stores/accountStore.ts on lines 66..74
client-reactnative/src/stores/walletStore.ts on lines 451..471

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      if (res.data.success || res.data === '') {
        this.getEmailList(token);
        showToast('success', 'Success', 'Email added succesfully', 'top');
      } else {
        runInAction(() => {
Severity: Minor
Found in client-reactnative/src/stores/accountStore.ts and 2 other locations - About 35 mins to fix
client-reactnative/src/stores/accountStore.ts on lines 98..106
client-reactnative/src/stores/walletStore.ts on lines 451..471

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status