Sign upLogin

datacite/bracco

View on GitHub
Star
cypress/e2e/staff_admin/repositories.test.ts

Summary

Maintainability
D
1 day
Test Coverage

Identical blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('[data-test-left-sidebar]').should('be.visible').within(($sidebar) => {
        // Create DOI button - would like to do more testing but seems impossible in Cypress.
        cy.get('.create-doi-button').contains(/Create DOI/i);
        cy.get('.create-doi-button button.dropdown-toggle').click({ force: true }).then(($obj) => {
          //cy.get('.create-doi-button ul.dropdown-menu')
Severity: Major
Found in cypress/e2e/staff_admin/repositories.test.ts and 3 other locations - About 3 hrs to fix
cypress/e2e/staff_admin/repositories.test.ts on lines 31..39
cypress/e2e/staff_admin/repositories.test.ts on lines 46..54
cypress/e2e/staff_admin/repositories.test.ts on lines 61..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('[data-test-left-sidebar]').should('be.visible').within(($sidebar) => {
        // Create DOI button - would like to do more testing but seems impossible in Cypress.
        cy.get('.create-doi-button').contains(/Create DOI/i);
        cy.get('.create-doi-button button.dropdown-toggle').click({ force: true }).then(($obj) => {
          //cy.get('.create-doi-button ul.dropdown-menu')
Severity: Major
Found in cypress/e2e/staff_admin/repositories.test.ts and 3 other locations - About 3 hrs to fix
cypress/e2e/staff_admin/repositories.test.ts on lines 31..39
cypress/e2e/staff_admin/repositories.test.ts on lines 46..54
cypress/e2e/staff_admin/repositories.test.ts on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('[data-test-left-sidebar]').should('be.visible').within(($sidebar) => {
          // Create DOI button - would like to do more testing but seems impossible in Cypress.
        cy.get('.create-doi-button').contains(/Create DOI/i);
        cy.get('.create-doi-button button.dropdown-toggle').click({ force: true }).then(($obj) => {
          //cy.get('.create-doi-button ul.dropdown-menu')
Severity: Major
Found in cypress/e2e/staff_admin/repositories.test.ts and 3 other locations - About 3 hrs to fix
cypress/e2e/staff_admin/repositories.test.ts on lines 31..39
cypress/e2e/staff_admin/repositories.test.ts on lines 61..69
cypress/e2e/staff_admin/repositories.test.ts on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('[data-test-left-sidebar]').should('be.visible').within(($sidebar) => {
          // Create DOI button - would like to do more testing but seems impossible in Cypress.
        cy.get('.create-doi-button').contains(/Create DOI/i);
        cy.get('.create-doi-button button.dropdown-toggle').click({ force: true }).then(($obj) => {
          //cy.get('.create-doi-button ul.dropdown-menu')
Severity: Major
Found in cypress/e2e/staff_admin/repositories.test.ts and 3 other locations - About 3 hrs to fix
cypress/e2e/staff_admin/repositories.test.ts on lines 46..54
cypress/e2e/staff_admin/repositories.test.ts on lines 61..69
cypress/e2e/staff_admin/repositories.test.ts on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

    before(function () {
      cy.login(Cypress.env('staff_admin_username'), Cypress.env('staff_admin_password'));
      cy.setCookie('_consent', 'true');
      cy.wait(waitTime2);
    })
Severity: Major
Found in cypress/e2e/staff_admin/repositories.test.ts and 18 other locations - About 1 hr to fix
cypress/e2e/client_admin/doi.test.ts on lines 19..23
cypress/e2e/client_admin/info.test.ts on lines 14..18
cypress/e2e/client_admin/prefixes.test.ts on lines 10..14
cypress/e2e/client_admin/settings.test.ts on lines 8..12
cypress/e2e/consortium_admin/contact.test.ts on lines 23..27
cypress/e2e/consortium_admin/doi.test.ts on lines 15..19
cypress/e2e/consortium_admin/info.test.ts on lines 13..17
cypress/e2e/consortium_admin/organizations.test.ts on lines 10..14
cypress/e2e/consortium_admin/prefixes.test.ts on lines 10..14
cypress/e2e/organization_admin/contact.test.ts on lines 23..27
cypress/e2e/organization_admin/doi.test.ts on lines 13..17
cypress/e2e/organization_admin/info.test.ts on lines 13..17
cypress/e2e/organization_admin/prefixes.test.ts on lines 10..14
cypress/e2e/staff_admin/admin.test.ts on lines 8..12
cypress/e2e/staff_admin/contact.test.ts on lines 26..30
cypress/e2e/staff_admin/info.test.ts on lines 12..16
cypress/e2e/staff_admin/prefix.test.ts on lines 8..12
cypress/e2e/staff_admin/settings.test.ts on lines 8..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status