Sign upLogin

datacite/lupo

View on GitHub
Star
app/controllers/concerns/facetable.rb

Summary

Maintainability
D
2 days
Test Coverage
F
28%

File facetable.rb has 492 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Facetable
  extend ActiveSupport::Concern

  SOURCES = {
    "datacite-usage" => "DataCite Usage Stats",
Severity: Minor
Found in app/controllers/concerns/facetable.rb - About 7 hrs to fix

    Method _facet_by_general_contributor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def _facet_by_general_contributor(arr, aggregate, source)
      arr.map { |hsh|
        orcid_id = %r{\A(?:(http|https)://(orcid.org)/)(.+)\z}.match?(hsh["key"]) && hsh["key"]

        if orcid_id.nil?
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method facet_by_funders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def facet_by_funders(arr)
      arr.map { |hsh|
        funder_id = hsh["key"]

        if funder_id.nil?
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def facet_by_citation_type_v1(arr)
      arr.map do |hsh|
        year_month_arr =
          hsh.dig("year_month", "buckets").map do |h|
            {
    Severity: Major
    Found in app/controllers/concerns/facetable.rb and 4 other locations - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 281..296
    app/controllers/concerns/facetable.rb on lines 301..316
    app/controllers/concerns/facetable.rb on lines 321..336
    app/controllers/concerns/facetable.rb on lines 361..376

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def facet_by_registrants(arr)
      arr.map do |hsh|
        year_arr =
          hsh.dig("year", "buckets").map do |h|
            {
    Severity: Major
    Found in app/controllers/concerns/facetable.rb and 4 other locations - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 281..296
    app/controllers/concerns/facetable.rb on lines 301..316
    app/controllers/concerns/facetable.rb on lines 321..336
    app/controllers/concerns/facetable.rb on lines 341..356

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                {
              "id" => hsh["key"],
              "title" => providers[hsh["key"].upcase],
              "count" => hsh["doc_count"],
              "temporal" => {
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 1 other location - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 431..441

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def facet_by_citation_type(arr)
      arr.map do |hsh|
        year_month_arr =
          hsh.dig("year_month", "buckets").map do |h|
            {
    Severity: Major
    Found in app/controllers/concerns/facetable.rb and 4 other locations - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 281..296
    app/controllers/concerns/facetable.rb on lines 301..316
    app/controllers/concerns/facetable.rb on lines 341..356
    app/controllers/concerns/facetable.rb on lines 361..376

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
          "id" => hsh["key"],
          "title" => clients[hsh["key"].upcase],
          "count" => hsh["doc_count"],
          "temporal" => {
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 1 other location - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 393..403

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def facet_by_relation_type_v1(arr)
      arr.map do |hsh|
        year_month_arr =
          hsh.dig("year_month", "buckets").map do |h|
            {
    Severity: Major
    Found in app/controllers/concerns/facetable.rb and 4 other locations - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 281..296
    app/controllers/concerns/facetable.rb on lines 321..336
    app/controllers/concerns/facetable.rb on lines 341..356
    app/controllers/concerns/facetable.rb on lines 361..376

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def facet_by_relation_type(arr)
      arr.map do |hsh|
        year_month_arr =
          hsh.dig("year_month", "buckets").map do |h|
            {
    Severity: Major
    Found in app/controllers/concerns/facetable.rb and 4 other locations - About 50 mins to fix
    app/controllers/concerns/facetable.rb on lines 301..316
    app/controllers/concerns/facetable.rb on lines 321..336
    app/controllers/concerns/facetable.rb on lines 341..356
    app/controllers/concerns/facetable.rb on lines 361..376

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def facet_by_client_type(arr)
      arr.map do |hsh|
        {
          "id" => hsh["key"],
          "title" => CLIENT_TYPES[hsh["key"]] || hsh["key"],
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 3 other locations - About 15 mins to fix
    app/controllers/concerns/facetable.rb on lines 137..142
    app/controllers/concerns/facetable.rb on lines 233..238
    app/controllers/concerns/facetable.rb on lines 271..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def facet_by_registration_agency(arr)
      arr.map do |hsh|
        {
          "id" => hsh["key"],
          "title" => REGISTRATION_AGENCIES[hsh["key"]] || hsh["key"],
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 3 other locations - About 15 mins to fix
    app/controllers/concerns/facetable.rb on lines 213..218
    app/controllers/concerns/facetable.rb on lines 233..238
    app/controllers/concerns/facetable.rb on lines 271..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def facet_by_source(arr)
      arr.map do |hsh|
        {
          "id" => hsh["key"],
          "title" => SOURCES[hsh["key"]] || hsh["key"],
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 3 other locations - About 15 mins to fix
    app/controllers/concerns/facetable.rb on lines 137..142
    app/controllers/concerns/facetable.rb on lines 213..218
    app/controllers/concerns/facetable.rb on lines 233..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def facet_by_license(arr)
      arr.map do |hsh|
        {
          "id" => hsh["key"],
          "title" => LICENSES[hsh["key"]] || hsh["key"],
    Severity: Minor
    Found in app/controllers/concerns/facetable.rb and 3 other locations - About 15 mins to fix
    app/controllers/concerns/facetable.rb on lines 137..142
    app/controllers/concerns/facetable.rb on lines 213..218
    app/controllers/concerns/facetable.rb on lines 271..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status