Sign upLogin

datacite/lupo

View on GitHub
Star
app/controllers/exports_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Method repositories has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

  def repositories
    # authorize! :export, :repositories

    # Loop through all clients
    page = { size: 1_000, number: 1 }
Severity: Minor
Found in app/controllers/exports_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method repositories has 143 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def repositories
    # authorize! :export, :repositories

    # Loop through all clients
    page = { size: 1_000, number: 1 }
Severity: Major
Found in app/controllers/exports_controller.rb - About 5 hrs to fix

    Method organizations has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def organizations
    authorize! :export, :organizations

    begin
      # Loop through all providers
    Severity: Major
    Found in app/controllers/exports_controller.rb - About 4 hrs to fix

      File exports_controller.rb has 315 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class ExportsController < ApplicationController
  include ActionController::MimeResponds

  before_action :authenticate_user_with_basic_auth!
      Severity: Minor
      Found in app/controllers/exports_controller.rb - About 3 hrs to fix

        Method organizations has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def organizations
    authorize! :export, :organizations

    begin
      # Loop through all providers
        Severity: Minor
        Found in app/controllers/exports_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method contacts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def contacts
    authorize! :export, :contacts

    headers = %w[uid fabricaAccountId fabricaId email firstName lastName type createdAt modifiedAt deletedAt isActive]
        Severity: Minor
        Found in app/controllers/exports_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            while page_num <= total_pages
      page = { size: 1_000, number: page_num }
      response =
        Client.query(
          nil,
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 40 mins to fix
        app/controllers/exports_controller.rb on lines 71..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              while page_num <= total_pages
        page = { size: 1_000, number: page_num }
        response =
          Provider.query(
            nil,
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 40 mins to fix
        app/controllers/exports_controller.rb on lines 192..204

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            totals_buckets.each do |totals|
      client_totals[totals["key"]] = {
        "count" => totals["doc_count"],
        "this_year" => totals.this_year.buckets[0]["doc_count"],
        "last_year" => totals.last_year.buckets[0]["doc_count"],
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/exports_controller.rb on lines 237..241

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            draft_totals_buckets.each do |totals|
      draft_client_totals[totals["key"]] = {
        "count" => totals["doc_count"],
        "this_year" => totals.this_year.buckets[0]["doc_count"],
        "last_year" => totals.last_year.buckets[0]["doc_count"],
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/exports_controller.rb on lines 219..223

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            rescue StandardError,
           Elasticsearch::Transport::Transport::Errors::BadRequest => e
      Raven.capture_exception(e)

      render json: { "errors" => { "title" => e.message } }.to_json,
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 15 mins to fix
        app/controllers/exports_controller.rb on lines 335..341

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          rescue StandardError,
         Elasticsearch::Transport::Transport::Errors::BadRequest => e
    Raven.capture_exception(e)

    render json: { "errors" => { "title" => e.message } }.to_json,
        Severity: Minor
        Found in app/controllers/exports_controller.rb and 1 other location - About 15 mins to fix
        app/controllers/exports_controller.rb on lines 163..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status