datacite/lupo

View on GitHub
app/lib/params_sanitizer.rb

Summary

Maintainability
C
1 day
Test Coverage

File params_sanitizer.rb has 432 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class ParamsSanitizer
  include Crosscitable
  include Helpable

  DEFAULTS_MAP =
Severity: Minor
Found in app/lib/params_sanitizer.rb - About 6 hrs to fix

    Method cleanse has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def cleanse
        xml = add_xml
    
        meta = generate_meta(xml)
        add_schema_version(meta)
    Severity: Major
    Found in app/lib/params_sanitizer.rb - About 2 hrs to fix

      Method add_xml_attributes has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def add_xml_attributes(meta)
          read_attrs_keys = %i[
            url
            creators
            contributors
      Severity: Minor
      Found in app/lib/params_sanitizer.rb - About 1 hr to fix

        Method cleanse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def cleanse
            xml = add_xml
        
            meta = generate_meta(xml)
            add_schema_version(meta)
        Severity: Minor
        Found in app/lib/params_sanitizer.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status