Sign upLogin

datacite/lupo

View on GitHub
Star
app/models/concerns/mailable.rb

Summary

Maintainability
C
1 day
Test Coverage
F
20%

Method send_welcome_email has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def send_welcome_email(responsible_id: nil)
      if instance_of?(Provider)
        client_id = nil
        provider_id = symbol.downcase
      elsif instance_of?(Client)
Severity: Major
Found in app/models/concerns/mailable.rb - About 3 hrs to fix

    Method send_welcome_email has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_welcome_email(responsible_id: nil)
      if instance_of?(Provider)
        client_id = nil
        provider_id = symbol.downcase
      elsif instance_of?(Client)
    Severity: Minor
    Found in app/models/concerns/mailable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_delete_email has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def send_delete_email(responsible_id: nil)
      title = Rails.env.stage? ? "DataCite Fabrica Test" : "DataCite Fabrica"
      subject = "#{title}: Account Deleted"
      account_type =
        if instance_of?(Provider)
    Severity: Minor
    Found in app/models/concerns/mailable.rb - About 1 hr to fix

      Method send_notification_to_slack has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_notification_to_slack(text, options = {})
      return nil if ENV["SLACK_WEBHOOK_URL"].blank?

      attachment = {
        title: options[:title] || "Fabrica Message",
      Severity: Minor
      Found in app/models/concerns/mailable.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send_delete_email has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_delete_email(responsible_id: nil)
      title = Rails.env.stage? ? "DataCite Fabrica Test" : "DataCite Fabrica"
      subject = "#{title}: Account Deleted"
      account_type =
        if instance_of?(Provider)
      Severity: Minor
      Found in app/models/concerns/mailable.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            fields = [
        { title: "Account ID", value: symbol, short: true },
        { title: "Account type", value: account_type, short: true },
        { title: "Account name", value: name, short: true },
        { title: "System email", value: system_email, short: true },
      Severity: Minor
      Found in app/models/concerns/mailable.rb and 1 other location - About 35 mins to fix
      app/models/concerns/mailable.rb on lines 81..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            fields = [
        { title: "Account ID", value: symbol, short: true },
        { title: "Account type", value: account_type, short: true },
        { title: "Account name", value: name, short: true },
        { title: "System email", value: system_email, short: true },
      Severity: Minor
      Found in app/models/concerns/mailable.rb and 1 other location - About 35 mins to fix
      app/models/concerns/mailable.rb on lines 130..136

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status