Sign upLogin

datacite/lupo

View on GitHub
Star
app/models/reference_repository.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
45%

File reference_repository.rb has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

class ReferenceRepository < ApplicationRecord
  include Indexable
  include Elasticsearch::Model
  include Hashid::Rails
  hashid_config alphabet: "abcdefghijklmnopqrstuvwxyz" \
Severity: Minor
Found in app/models/reference_repository.rb - About 4 hrs to fix

    Class ReferenceRepository has 22 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

    class ReferenceRepository < ApplicationRecord
  include Indexable
  include Elasticsearch::Model
  include Hashid::Rails
  hashid_config alphabet: "abcdefghijklmnopqrstuvwxyz" \
    Severity: Minor
    Found in app/models/reference_repository.rb - About 2 hrs to fix

      Method filter has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

            def filter(options)
        retval = []
        if options[:year].present?
          retval << { terms: {
            "year": options[:year].split(",")
      Severity: Major
      Found in app/models/reference_repository.rb - About 2 hrs to fix

        Method query_aggregations has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

            def query_aggregations(facet_count: 10)
      if facet_count.positive?
        {
          years: {
            date_histogram: {
        Severity: Minor
        Found in app/models/reference_repository.rb - About 1 hr to fix

          Method query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

              def query(query, options = {})
      options[:page] ||= {}
      options[:page][:number] ||= 1
      options[:page][:size] ||= 25
      options[:sort] ||= sort_fields
          Severity: Minor
          Found in app/models/reference_repository.rb - About 1 hr to fix

            Method filter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                  def filter(options)
        retval = []
        if options[:year].present?
          retval << { terms: {
            "year": options[:year].split(",")
            Severity: Minor
            Found in app/models/reference_repository.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                def query(query, options = {})
      options[:page] ||= {}
      options[:page][:number] ||= 1
      options[:page][:size] ||= 25
      options[:sort] ||= sort_fields
            Severity: Minor
            Found in app/models/reference_repository.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status