datacite/lupo

View on GitHub
app/models/user.rb

Summary

Maintainability
C
1 day
Test Coverage
F
22%

Method reset has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.reset(username)
    uid = username.downcase

    if uid.include?(".")
      user = Client.where(symbol: uid.upcase).where(deleted_at: nil).first
Severity: Major
Found in app/models/user.rb - About 3 hrs to fix

    Method initialize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(credentials, options = {})
        if credentials.present? && options.fetch(:type, "").casecmp("basic").zero?
          username, password = ::Base64.decode64(credentials).split(":", 2)
          payload = decode_auth_param(username: username, password: password)
          @jwt =
    Severity: Minor
    Found in app/models/user.rb - About 1 hr to fix

      Method reset has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.reset(username)
          uid = username.downcase
      
          if uid.include?(".")
            user = Client.where(symbol: uid.upcase).where(deleted_at: nil).first
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(credentials, options = {})
          if credentials.present? && options.fetch(:type, "").casecmp("basic").zero?
            username, password = ::Base64.decode64(credentials).split(":", 2)
            payload = decode_auth_param(username: username, password: password)
            @jwt =
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status