Sign upLogin

datacite/spinone

View on GitHub
Star
app/models/work.rb

Summary

Maintainability
F
5 days
Test Coverage

Method get_query_url has a Cognitive Complexity of 93 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_query_url(options={})
    if options[:id].present?
      params = { q: "doi:#{options[:id]}",
                 wt: "json" }
    elsif options[:work_id].present?
Severity: Minor
Found in app/models/work.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_data has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse_data(result, options={})
    return result if result['errors']
    data = nil

    if options[:id].present?
Severity: Minor
Found in app/models/work.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_query_url has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_query_url(options={})
    if options[:id].present?
      params = { q: "doi:#{options[:id]}",
                 wt: "json" }
    elsif options[:work_id].present?
Severity: Major
Found in app/models/work.rb - About 4 hrs to fix

    File work.rb has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Work < Base
  attr_reader :id, :doi, :identifier, :cache_key, :url, :author, :title, :container_title, :description, :resource_type_subtype, :data_center_id, :member_id, :resource_type_id, :data_center, :member, :resource_type, :license, :version, :results, :related_identifiers, :schema_version, :xml, :media, :checked, :published, :registered, :updated

  # include author methods
  include Authorable
    Severity: Minor
    Found in app/models/work.rb - About 4 hrs to fix

      Method parse_data has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.parse_data(result, options={})
    return result if result['errors']
    data = nil

    if options[:id].present?
      Severity: Major
      Found in app/models/work.rb - About 2 hrs to fix

        Method normalize_license has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

          def normalize_license(licenses)
    uri = licenses.map { |l| URI.parse(l) }.find { |l| l.host && l.host[/(creativecommons.org|opensource.org)$/] }
    return nil unless uri.present?

    # use HTTPS
        Severity: Minor
        Found in app/models/work.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(attributes={}, options={})
    @doi = attributes.fetch("doi", "").downcase.presence
    @identifier = attributes.fetch("id", nil).presence || doi_as_url(attributes.fetch("doi", nil))
    @id = @identifier
        Severity: Minor
        Found in app/models/work.rb - About 1 hr to fix

          Method parse_facet_counts has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.parse_facet_counts(facets, options={})
    resource_types = Array.wrap(facets.dig("facet_fields", "resourceType_facet"))
                           .each_slice(2)
                           .map { |k,v| { id: k.underscore.dasherize, title: k.underscore.humanize, count: v } }
    registered = Array.wrap(facets.dig("facet_ranges", "minted", "counts"))
          Severity: Minor
          Found in app/models/work.rb - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                    return { data: [], meta: [] } if items.blank?
            Severity: Major
            Found in app/models/work.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return { data: [], meta: [] } if related_doi_identifiers.blank?
              Severity: Major
              Found in app/models/work.rb - About 30 mins to fix

                Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def initialize(attributes={}, options={})
    @doi = attributes.fetch("doi", "").downcase.presence
    @identifier = attributes.fetch("id", nil).presence || doi_as_url(attributes.fetch("doi", nil))
    @id = @identifier
                Severity: Minor
                Found in app/models/work.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        samples_per_page = (1..100).include?(options[:sample].to_i) ? options[:sample].to_i : 10
        per_page = options.dig(:page, :size).to_i * samples_per_page
        per_page = (1..1000).include?(per_page) ? per_page : 1000
      elsif options[:sample].present? && options[:sample_group].blank?
                Severity: Minor
                Found in app/models/work.rb and 1 other location - About 25 mins to fix
                app/models/work.rb on lines 293..296

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 29.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        samples_per_page = (1..100).include?(options[:sample].to_i) ? options[:sample].to_i : 10
        per_page = options.dig(:page, :size).to_i * samples_per_page
        per_page = (1..1000).include?(per_page) ? per_page : 1000
      elsif options[:sample].present? && options[:sample_group].blank?
                Severity: Minor
                Found in app/models/work.rb and 1 other location - About 25 mins to fix
                app/models/work.rb on lines 159..162

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 29.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status