Sign upLogin

datacoves/dbt-coves

View on GitHub
Star
dbt_coves/tasks/generate/airflow_generators/airbyte.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function get_pipeline_connection_ids has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def get_pipeline_connection_ids(self, db: str, schema: str, table: str) -> str:
        """
        Given a table name, schema and db, returns the corresponding Airbyte Connection ID
        """
        airbyte_tables = []
Severity: Minor
Found in dbt_coves/tasks/generate/airflow_generators/airbyte.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(
Severity: Major
Found in dbt_coves/tasks/generate/airflow_generators/airbyte.py - About 1 hr to fix

    Function _get_connection_schema has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _get_connection_schema(self, conn, destination_config):
        """Given an airybte connection, returns a schema name"""
        namespace_definition = conn["namespaceDefinition"]

        if namespace_definition == "source" or (
    Severity: Minor
    Found in dbt_coves/tasks/generate/airflow_generators/airbyte.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if (airbyte_schema == schema or not airbyte_schema) and conn.get(
                            "connectionId"
                        ) not in connection_ids:
                            connection_ids.append(conn["connectionId"])
        if connection_ids:
    Severity: Major
    Found in dbt_coves/tasks/generate/airflow_generators/airbyte.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status