Sign upLogin

datahuborg/datahub

View on GitHub
Star
src/account/utils.py

Summary

Maintainability
A
1 hr
Test Coverage

Function datahub_authenticate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def datahub_authenticate(username, password):
    """
    Analog of django.contrib.auth.authenticate.

    Given a username or email plus password, finds the User object, verifies
Severity: Minor
Found in src/account/utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not use bare 'except'
Open

        except:
Severity: Minor
Found in src/account/utils.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:

There are no issues that match your filters.

Category
Status