datahuborg/datahub

View on GitHub
src/functional_tests/test_console.py

Summary

Maintainability
D
2 days
Test Coverage

Function test_connect_to_new_user has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_connect_to_new_user(self):
        # names
        users = ['delete_me_one', 'delete_me_two', 'i_dont_exist']
        repo_shared = 'one_two'
        repo_user1_only = 'one'
Severity: Minor
Found in src/functional_tests/test_console.py - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_cannot_create_bad_repos(self):
            bad_repo_names = ['one space', '_introUnderscore', 'semi;colon']
    
            self.sign_up_manually()
            self.navigate_to_terminal()
    Severity: Major
    Found in src/functional_tests/test_console.py and 1 other location - About 7 hrs to fix
    src/functional_tests/test_console.py on lines 53..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_create_repos(self):
            good_repo_names = ['nospace', 'alph4numeric', 'middle_underscore']
    
            self.sign_up_manually()
            self.navigate_to_terminal()
    Severity: Major
    Found in src/functional_tests/test_console.py and 1 other location - About 7 hrs to fix
    src/functional_tests/test_console.py on lines 108..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            self.wait_for_console(
                users[1] + "@" + users[0] + ">", "//div[@class='cmd']/span[1]")
    Severity: Major
    Found in src/functional_tests/test_console.py and 1 other location - About 1 hr to fix
    src/functional_tests/test_console.py on lines 265..266

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            self.wait_for_console(
                users[1] + "@" + users[1] + ">", "//div[@class='cmd']/span[1]")
    Severity: Major
    Found in src/functional_tests/test_console.py and 1 other location - About 1 hr to fix
    src/functional_tests/test_console.py on lines 249..250

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Missing whitespace after keyword
    Open

    from account.management.commands.createoauthappsandowner import(
    Severity: Minor
    Found in src/functional_tests/test_console.py by pep8

    Multiple imports in form from x import (a, b, c) should have space between import statement and parenthesised name list.

    Okay: from foo import (bar, baz)
    E275: from foo import(bar, baz)
    E275: from importable.module import(bar, baz)

    There are no issues that match your filters.

    Category
    Status