datamapper/dm-core

View on GitHub
lib/dm-core/model.rb

Summary

Maintainability
D
1 day
Test Coverage

Method load has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.

    def load(records, query)
      repository      = query.repository
      repository_name = repository.name
      fields          = query.fields
      discriminator   = properties(repository_name).discriminator
Severity: Minor
Found in lib/dm-core/model.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File model.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.

module DataMapper
  module Model
    include Enumerable

    WRITER_METHOD_REGEXP   = /=\z/.freeze
Severity: Minor
Found in lib/dm-core/model.rb - About 4 hrs to fix

    Method load has 49 lines of code (exceeds 25 allowed). Consider refactoring.

        def load(records, query)
          repository      = query.repository
          repository_name = repository.name
          fields          = query.fields
          discriminator   = properties(repository_name).discriminator
    Severity: Minor
    Found in lib/dm-core/model.rb - About 1 hr to fix

      Method scoped_query has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

          def scoped_query(query)
            if query.kind_of?(Query)
              query.dup
            else
              repository = if query.key?(:repository)
      Severity: Minor
      Found in lib/dm-core/model.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method first has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

          def first(*args)
            first_arg = args.first
            last_arg  = args.last
      
            limit_specified = first_arg.kind_of?(Integer)
      Severity: Minor
      Found in lib/dm-core/model.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method last has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

          def last(*args)
            first_arg = args.first
            last_arg  = args.last
      
            limit_specified = first_arg.kind_of?(Integer)
      Severity: Minor
      Found in lib/dm-core/model.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category