Sign upLogin

datamapper/dm-core

View on GitHub
Star
lib/dm-core/model/relationship.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method assert_valid_options has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. 

      def assert_valid_options(options)
        # TODO: update to match Query#assert_valid_options
        #   - perform options normalization elsewhere

        if options.key?(:min) && options.key?(:max)
Severity: Minor
Found in lib/dm-core/model/relationship.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method assert_valid_options has 39 lines of code (exceeds 25 allowed). Consider refactoring. 

      def assert_valid_options(options)
        # TODO: update to match Query#assert_valid_options
        #   - perform options normalization elsewhere

        if options.key?(:min) && options.key?(:max)
Severity: Minor
Found in lib/dm-core/model/relationship.rb - About 1 hr to fix

    Method has has 26 lines of code (exceeds 25 allowed). Consider refactoring. 

          def has(cardinality, name, *args)
        name    = name.to_sym
        model   = extract_model(args)
        options = extract_options(args)
    Severity: Minor
    Found in lib/dm-core/model/relationship.rb - About 1 hr to fix

      Method has has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. 

            def has(cardinality, name, *args)
        name    = name.to_sym
        model   = extract_model(args)
        options = extract_options(args)
      Severity: Minor
      Found in lib/dm-core/model/relationship.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category