datamapper/dm-core

View on GitHub
lib/dm-core/support/lazy_array.rb

Summary

Maintainability
D
2 days
Test Coverage

Class LazyArray has 43 methods (exceeds 20 allowed). Consider refactoring.

class LazyArray  # borrowed partially from StrokeDB
  include Enumerable

  attr_reader :head, :tail

Severity: Minor
Found in lib/dm-core/support/lazy_array.rb - About 5 hrs to fix

    File lazy_array.rb has 361 lines of code (exceeds 250 allowed). Consider refactoring.

    class LazyArray  # borrowed partially from StrokeDB
      include Enumerable
    
      attr_reader :head, :tail
    
    
    Severity: Minor
    Found in lib/dm-core/support/lazy_array.rb - About 4 hrs to fix

      Method cmp? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

        def cmp?(other, operator)
          unless loaded?
            # compare the head against the beginning of other.  start at index
            # 0 and incrementally compare each entry. if other is a LazyArray
            # this has a lesser likelyhood of triggering a lazy load
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method extract_slice_arguments has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

        def extract_slice_arguments(*args)
          first_arg, second_arg = args
      
          if args.size == 2 && first_arg.kind_of?(Integer) && second_arg.kind_of?(Integer)
            return first_arg, second_arg
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method values_at has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

        def values_at(*args)
          accumulator = []
      
          lazy_possible = args.all? do |arg|
            index, length = extract_slice_arguments(arg)
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.

          if index >= 0 && lazy_possible?(@head, index + length)
            @head[*args]
          elsif index < 0 && lazy_possible?(@tail, index.abs - 1 + length)
            @tail[*args]
          else
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb and 2 other locations - About 40 mins to fix
      lib/dm-core/support/lazy_array.rb on lines 122..129
      lib/dm-core/support/lazy_array.rb on lines 135..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.

          if index >= 0 && lazy_possible?(@head, index + length)
            @head.slice!(*args)
          elsif index < 0 && lazy_possible?(@tail, index.abs - 1 + length)
            @tail.slice!(*args)
          else
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb and 2 other locations - About 40 mins to fix
      lib/dm-core/support/lazy_array.rb on lines 107..114
      lib/dm-core/support/lazy_array.rb on lines 135..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.

          if index >= 0 && lazy_possible?(@head, index + length)
            @head.[]=(*args)
          elsif index < 0 && lazy_possible?(@tail, index.abs - 1 + length)
            @tail.[]=(*args)
          else
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb and 2 other locations - About 40 mins to fix
      lib/dm-core/support/lazy_array.rb on lines 107..114
      lib/dm-core/support/lazy_array.rb on lines 122..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.

        def delete_at(index)
          if index >= 0 && lazy_possible?(@head, index + 1)
            @head.delete_at(index)
          elsif index < 0 && lazy_possible?(@tail, index.abs)
            @tail.delete_at(index)
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb and 1 other location - About 30 mins to fix
      lib/dm-core/support/lazy_array.rb on lines 24..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.

        def at(index)
          if index >= 0 && lazy_possible?(@head, index + 1)
            @head.at(index)
          elsif index < 0 && lazy_possible?(@tail, index.abs)
            @tail.at(index)
      Severity: Minor
      Found in lib/dm-core/support/lazy_array.rb and 1 other location - About 30 mins to fix
      lib/dm-core/support/lazy_array.rb on lines 239..247

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category