Showing 9 of 14 total issues
File storage.py has 270 lines of code (exceeds 250 allowed). Consider refactoring. Open
# coding=utf-8
"""Github Storage Backend implementation
This backend stores datasets as GitHub repositories, utilizing Git's built-in
revisions and tags. This implementation is based on GitHub's Web API, and willFile filesystem.py has 259 lines of code (exceeds 250 allowed). Consider refactoring. Open
"""Pyfilesystem based versioned metadata storage
This is useful especially for testing and POC implementations
"""
import hashlibFilesystemStorage has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class FilesystemStorage(StorageBackend):
"""Abstract filesystem based storage based on PyFilesystem
This storage backend is useful mostly in testing, especially with the
'mem://' file system. You most likely shouldn't be using it in production,GitHubStorage has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class GitHubStorage(StorageBackend):
"""GitHub based metadata storage
"""
DEFAULT_README = ('# ¯\\_(ツ)_/¯\n'Function _create_lfs_files has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def _create_lfs_files(self, datapackage):
# type: (Dict[str, Any]) -> List[gh.InputGitTreeElement]
"""Create LFS pointer files and config files, if we need to
:raise ValueError: If resources with conflicting file names are found- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def create(self, package_id, metadata, author=None, message=None):
owner, repo_name = self._parse_id(package_id)
datapackage = _create_file('datapackage.json', json.dumps(metadata, indent=2))
files = [datapackage] + self._create_lfs_files(metadata)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _create_tag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def _create_tag(self, repo, name, description, revision_ref, author):
# type: (gh.Repository, str, str, str, Optional[Author]) -> gh.GitTag.GitTag
"""Low level operations for creating a git tag
"""
author = self._verify_author(author)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function tag_update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def tag_update(self, package_id, tag, author=None, new_name=None, new_description=None):
if new_name is None and new_description is None:
raise ValueError("Expecting at least one of new_name or new_description to be specified")
repo = self._get_repo(package_id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def fetch(self, package_id, revision_ref=None, repo=None):
if repo is None:
repo = self._get_repo(package_id)
try:
if not revision_ref:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"