davaxi/AllMySMS

View on GitHub

Showing 43 of 43 total issues

Method callSMS has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function callSMS(SMS $sms, $simulate)
    {
        $data = $sms->getData();
        $this->checkSMSData($data);

Severity: Minor
Found in src/Service/Message/OutGoing.php - About 1 hr to fix

    Method sendMMS has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function sendMMS(MMS $mms)
        {
            $data = $mms->getData();
            $this->checkMMSData($data);
    
    
    Severity: Minor
    Found in src/Service/Message/OutGoing.php - About 1 hr to fix

      Method getDefaultSubAccountData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getDefaultSubAccountData()
          {
              return [
                  'FIRSTNAME' => '',
                  'LASTNAME' => '',
      Severity: Minor
      Found in src/Service/Account.php - About 1 hr to fix

        Function checkSubAccountData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function checkSubAccountData(array $data)
            {
                if (!$data['FIRSTNAME']) {
                    throw new \InvalidArgumentException('Missing FIRSTNAME');
                }
        Severity: Minor
        Found in src/Service/Account.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Missing class import via use statement (line '64', column '23').
        Open

                    throw new \InvalidArgumentException('Invalid sender. Only allowed a-z / A-Z / 0-9');
        Severity: Minor
        Found in src/Model.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '58', column '23').
        Open

                    throw new \InvalidArgumentException('Invalid sender. Max allowed ' . static::SENDER_MAX_LENGTH . ' chars.');
        Severity: Minor
        Found in src/Model.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '284', column '23').
        Open

                    throw new \LogicException('No SUBJECT defined');
        Severity: Minor
        Found in src/Service/Message/OutGoing.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '92', column '23').
        Open

                    throw new \InvalidArgumentException('Invalid recipient number : ' . $recipient . '. Only international format started with 00 or +. Or french number');
        Severity: Minor
        Found in src/Model.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '287', column '23').
        Open

                    throw new \LogicException('No HTML defined');
        Severity: Minor
        Found in src/Service/Message/OutGoing.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '40', column '27').
        Open

                        throw new \InvalidArgumentException('Missing FIELDNAME');
        Severity: Minor
        Found in src/Service/ContactList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '234', column '23').
        Open

                    throw new \LogicException('No recipients defined');
        Severity: Minor
        Found in src/Service/Message/OutGoing.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '285', column '23').
        Open

                    throw new \InvalidArgumentException('PASSWORD need min 6 char');
        Severity: Minor
        Found in src/Service/Account.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '216', column '27').
        Open

                        throw new \InvalidArgumentException('Missing MOBILEPHONE field');
        Severity: Minor
        Found in src/Service/ContactList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '255', column '23').
        Open

                    throw new \LogicException('No mms type defined');
        Severity: Minor
        Found in src/Service/Message/OutGoing.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '265', column '23').
        Open

                    throw new \LogicException('No recipients defined');
        Severity: Minor
        Found in src/Service/Message/OutGoing.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '97', column '23').
        Open

                    throw new \LogicException('You can\'t have multiple MMS resource');
        Severity: Minor
        Found in src/Model/MMS.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '106', column '27').
        Open

                        throw new \InvalidArgumentException('Invalid params key ' . $key . '. Expected key : ' . $expectedKey);
        Severity: Minor
        Found in src/Model.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '199', column '23').
        Open

                    throw new \InvalidArgumentException('Invalid picture path. Allowed only : ' . static::ALLOWED_PICTURE_EXTENSIONS);
        Severity: Minor
        Found in src/Model.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '270', column '23').
        Open

                    throw new \InvalidArgumentException('Missing FIRSTNAME');
        Severity: Minor
        Found in src/Service/Account.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '282', column '23').
        Open

                    throw new \InvalidArgumentException('Missing PASSWORD');
        Severity: Minor
        Found in src/Service/Account.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Severity
        Category
        Status
        Source
        Language