Sign upLogin

davaxi/AllMySMS

View on GitHub
Star

Showing 4 of 43 total issues

Method callSMS has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function callSMS(SMS $sms, $simulate)
    {
        $data = $sms->getData();
        $this->checkSMSData($data);
Severity: Minor
Found in src/Service/Message/OutGoing.php - About 1 hr to fix

    Method sendMMS has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function sendMMS(MMS $mms)
    {
        $data = $mms->getData();
        $this->checkMMSData($data);
    Severity: Minor
    Found in src/Service/Message/OutGoing.php - About 1 hr to fix

      Method getDefaultSubAccountData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getDefaultSubAccountData()
    {
        return [
            'FIRSTNAME' => '',
            'LASTNAME' => '',
      Severity: Minor
      Found in src/Service/Account.php - About 1 hr to fix

        Function checkSubAccountData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function checkSubAccountData(array $data)
    {
        if (!$data['FIRSTNAME']) {
            throw new \InvalidArgumentException('Missing FIRSTNAME');
        }
        Severity: Minor
        Found in src/Service/Account.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language