Sign upLogin

davaxi/Takuzu

View on GitHub
Star

Showing 31 of 31 total issues

Missing class import via use statement (line '146', column '27').
Open

                throw new \InvalidArgumentException('The grid does not form a rectangle.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/ResolverMethod/NoThreeCenter.php - About 30 mins to fix

Missing class import via use statement (line '41', column '19').
Open

        throw new \UnexpectedValueException('Unknown value: ' . $value);
Severity: Minor
Found in src/GridHelpers.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '122', column '23').
Open

            throw new \LogicException('Grid already resolved');
Severity: Minor
Found in src/Resolver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '133', column '23').
Open

            throw new \InvalidArgumentException('The grid should have an even number line.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/ResolverMethod/NoThreeSide.php - About 30 mins to fix

Missing class import via use statement (line '23', column '19').
Open

        throw new \InvalidArgumentException('Not exist reverse value for undefined');
Severity: Minor
Found in src/GridHelpers.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/GridChecker.php - About 30 mins to fix

Missing class import via use statement (line '105', column '23').
Open

            throw new \LogicException('Invalid call to method');
Severity: Minor
Found in src/ResolverSeriesGenerator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '27').
Open

                throw new \InvalidArgumentException('The grid should have an even number of column.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function checkLineValuesCollision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function checkLineValuesCollision(array $line)
    {
        $previousValue = null;
        $previousValueCount = 1;
        foreach ($line as $value) {
Severity: Minor
Found in src/GridChecker.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language