Sign upLogin

davaxi/Takuzu

View on GitHub
Star
src/Grid.php

Summary

Maintainability
A
4 hrs
Test Coverage

Function setGridFromArray has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function setGridFromArray(array $grid)
    {
        $lineCount = count($grid);
        if ($lineCount % 2 !== 0) {
            throw new \InvalidArgumentException('The grid should have an even number line.');
Severity: Minor
Found in src/Grid.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setGridFromArray has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setGridFromArray(array $grid)
    {
        $lineCount = count($grid);
        if ($lineCount % 2 !== 0) {
            throw new \InvalidArgumentException('The grid should have an even number line.');
Severity: Minor
Found in src/Grid.php - About 1 hr to fix

Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($width = null, $height = null)
    {
        $this->checker = new GridChecker($this);
        $this->helpers = new GridHelpers();
        if (!is_null($width) && !is_null($height)) {
Severity: Minor
Found in src/Grid.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '133', column '23').
Open

            throw new \InvalidArgumentException('The grid should have an even number line.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '27').
Open

                throw new \InvalidArgumentException('The grid should have an even number of column.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '146', column '27').
Open

                throw new \InvalidArgumentException('The grid does not form a rectangle.');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '286', column '23').
Open

            throw new \LogicException('Not exist empty case');
Severity: Minor
Found in src/Grid.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status