Sign upLogin

davidawad/lobe

View on GitHub
Star

Showing 7 of 7 total issues

Function receive has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def receive(data: dict):
    """
    Handler for webhook (currently for postback and messages)
    Parses out the message and bubbles it up to the processing layer
    """
Severity: Minor
Found in app/messaging/fb_messenger.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function first_entity_value has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def first_entity_value(entities):
    """
    Returns first entity value
    """
    log("Entities " + str(entities))
Severity: Minor
Found in app/nlp_tools/proc_wit.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process_user_message has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def process_user_message(current_user: User) -> None:
    """
    procedure for new messages
    take the last message a user sent and send response for it
    :param User current_user: the user who sent the message
Severity: Minor
Found in app/processing.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if lat:

                        current_user.add_coordinates(lat, long)

                        print("USER IN STATE : " + current_user.state)
Severity: Major
Found in app/messaging/fb_messenger.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if not current_user:
                        current_user = User('fb', fb_id)
    Severity: Major
    Found in app/messaging/fb_messenger.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

              return
      Severity: Major
      Found in app/processing.py - About 30 mins to fix

        Function split_into_sentences has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def split_into_sentences(text):
    if not text:
        return []

    text = " " + text + "  "
        Severity: Minor
        Found in app/nlp_tools/proc_english.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language