Sign upLogin

davidbonachera/EdiParser

View on GitHub
Star

Showing 10 of 10 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        "50.20" => array(
            "CODEXC" => "50",
            "SEPEXC" => ".",
            "SCOEXC" => "20",
            "TRTEXC" => null,
Severity: Major
Found in Model/Infolog/M50.php and 1 other location - About 1 day to fix
Model/Infolog/M31.php on lines 75..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 269.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        "31.01" => array(
            "CODEXC" => "31",
            "SEPEXC" => ".",
            "SCOEXC" => "01",
            "TRTEXC" => null,
Severity: Major
Found in Model/Infolog/M31.php and 1 other location - About 1 day to fix
Model/Infolog/M50.php on lines 75..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 269.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        "20.01" => array(
            "CODEXC"=> "20",
            "SEPEXC"=> ".",
            "SCOEXC"=> "01",
            "TRTEXC"=> null,
Severity: Major
Found in Model/Infolog/M20.php and 1 other location - About 3 hrs to fix
Model/Infolog/M50.php on lines 53..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        "50.10" => array(
            "CODEXC" => "50",
            "SEPEXC" => ".",
            "SCOEXC" => "10",
            "TRTEXC" => null,
Severity: Major
Found in Model/Infolog/M50.php and 1 other location - About 3 hrs to fix
Model/Infolog/M20.php on lines 53..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File M30.php has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This file is part of the EdiParser package.
 *
 * @package     EdiParserBundle
Severity: Minor
Found in Model/Infolog/M30.php - About 3 hrs to fix

    Function writeLine has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function writeLine($line, $validationTemplate)
    {
        $str = "";
        $pos = 0;
        $i = 0;
    Severity: Minor
    Found in Parser/Writer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File M31.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This file is part of the EdiParser package.
 *
 * @package     EdiParserBundle
    Severity: Minor
    Found in Model/Infolog/M31.php - About 2 hrs to fix

      Function parse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function parse(ModelAbstract $model, array $rows = [], $identifierSize = 5)
    {
        if (empty($model)) {
            $this->errors["model"] = "No model given";
            return false;
      Severity: Minor
      Found in Parser/Reader.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function validate($data, $validationArray) {
        foreach ($validationArray as $key => $validation) {
            if($validation['required']) {
                $err = v::stringType()->notEmpty()->length(null, $validation['length']);
            } else {
      Severity: Minor
      Found in Model/ModelAbstract.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method writeLine has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function writeLine($line, $validationTemplate)
    {
        $str = "";
        $pos = 0;
        $i = 0;
      Severity: Minor
      Found in Parser/Writer.php - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language