Sign upLogin

davidbonachera/EdiParser

View on GitHub
Star

Showing 6 of 10 total issues

File M30.php has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This file is part of the EdiParser package.
 *
 * @package     EdiParserBundle
Severity: Minor
Found in Model/Infolog/M30.php - About 3 hrs to fix

    Function writeLine has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function writeLine($line, $validationTemplate)
    {
        $str = "";
        $pos = 0;
        $i = 0;
    Severity: Minor
    Found in Parser/Writer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File M31.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This file is part of the EdiParser package.
 *
 * @package     EdiParserBundle
    Severity: Minor
    Found in Model/Infolog/M31.php - About 2 hrs to fix

      Function parse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function parse(ModelAbstract $model, array $rows = [], $identifierSize = 5)
    {
        if (empty($model)) {
            $this->errors["model"] = "No model given";
            return false;
      Severity: Minor
      Found in Parser/Reader.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function validate($data, $validationArray) {
        foreach ($validationArray as $key => $validation) {
            if($validation['required']) {
                $err = v::stringType()->notEmpty()->length(null, $validation['length']);
            } else {
      Severity: Minor
      Found in Model/ModelAbstract.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method writeLine has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function writeLine($line, $validationTemplate)
    {
        $str = "";
        $pos = 0;
        $i = 0;
      Severity: Minor
      Found in Parser/Writer.php - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language