Sign upLogin

davidcelis/recommendable

View on GitHub
Star
lib/recommendable/helpers/calculations.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method update_recommendations_for has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def update_recommendations_for(user_id)
          user_id = user_id.to_s

          nearest_neighbors = Recommendable.config.nearest_neighbors || Recommendable.config.user_class.count
          Recommendable.config.ratable_classes.each do |klass|
Severity: Minor
Found in lib/recommendable/helpers/calculations.rb - About 1 hr to fix

    Method update_similarities_for has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def update_similarities_for(user_id)
          user_id = user_id.to_s # For comparison. Redis returns all set members as strings.
          similarity_set = Recommendable::Helpers::RedisKeyMapper.similarity_set_for(user_id)

          # Only calculate similarities for users who have rated the items that
    Severity: Minor
    Found in lib/recommendable/helpers/calculations.rb - About 1 hr to fix

      Method update_similarities_for has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def update_similarities_for(user_id)
          user_id = user_id.to_s # For comparison. Redis returns all set members as strings.
          similarity_set = Recommendable::Helpers::RedisKeyMapper.similarity_set_for(user_id)

          # Only calculate similarities for users who have rated the items that
      Severity: Minor
      Found in lib/recommendable/helpers/calculations.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status