Sign upLogin

davide-casiraghi/laravel-quick-menus

View on GitHub
Star

Showing 7 of 7 total issues

Function updateOrder has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateOrder($menuId, $parentItemId, $itemId, $position)
    {
        $menuItemsSameMenuAndLevel = $this->getItemsSameMenuAndLevel($menuId, $parentItemId, 0);
        $menuItem = new MenuItem();
Severity: Minor
Found in src/Http/Controllers/MenuItemController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateOrder has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateOrder($menuId, $parentItemId, $itemId, $position)
    {
        $menuItemsSameMenuAndLevel = $this->getItemsSameMenuAndLevel($menuId, $parentItemId, 0);
        $menuItem = new MenuItem();
Severity: Minor
Found in src/Http/Controllers/MenuItemController.php - About 1 hr to fix

    Function authorized has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function authorized()
    {
        $ret = false;
        $user = Auth::user();
    Severity: Minor
    Found in src/Models/MenuItem.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method authorized has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function authorized()
    {
        $ret = false;
        $user = Auth::user();
    Severity: Minor
    Found in src/Models/MenuItem.php - About 1 hr to fix

      Method boot has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function boot()
    {
        /*
         * Optional methods to load your package assets
         */
      Severity: Minor
      Found in src/LaravelQuickMenusServiceProvider.php - About 1 hr to fix

        Method saveOnDb has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function saveOnDb($request, $menuItem)
    {
        $menuItem->translateOrNew('en')->name = $request->get('name');
        $menuItem->translateOrNew('en')->slug = Str::slug($request->get('name'), '-');
        if (! $request->get('parent_item_id')) {
        Severity: Minor
        Found in src/Http/Controllers/MenuItemController.php - About 1 hr to fix

          Function boot has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function boot()
    {
        /*
         * Optional methods to load your package assets
         */
          Severity: Minor
          Found in src/LaravelQuickMenusServiceProvider.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language