Sign upLogin

davide-casiraghi/laravel-smart-blog

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace DavideCasiraghi\LaravelSmartBlog\Http\Controllers;

use Validator;
Severity: Major
Found in src/Http/Controllers/CategoryTranslationController.php and 1 other location - About 3 days to fix
src/Http/Controllers/BlogTranslationController.php on lines 1..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 594.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace DavideCasiraghi\LaravelSmartBlog\Http\Controllers;

use Validator;
Severity: Major
Found in src/Http/Controllers/BlogTranslationController.php and 1 other location - About 3 days to fix
src/Http/Controllers/CategoryTranslationController.php on lines 1..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 594.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File edit.blade.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

@extends('laravel-smart-blog::blogs.layout')

@section('content')
    <div class="container max-w-md px-0">
Severity: Minor
Found in resources/views/blogs/edit.blade.php - About 2 hrs to fix

    File create.blade.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    @extends('laravel-smart-blog::blogs.layout')

@section('content')
    <div class="container max-w-md px-0">
    Severity: Minor
    Found in resources/views/blogs/create.blade.php - About 2 hrs to fix

      Method boot has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function boot()
    {
        /*
         * Optional methods to load your package assets
         */
      Severity: Minor
      Found in src/LaravelSmartBlogServiceProvider.php - About 1 hr to fix

        Method index has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function index(Request $request)
    {
        //$categories = Category::getCategoriesArray();
        $categories = Category::listsTranslations('name')->pluck('name', 'id');
        Severity: Minor
        Found in src/Http/Controllers/PostController.php - About 1 hr to fix

          Method uploadImageOnServer has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function uploadImageOnServer($imageFile, $imageName, $imageSubdir, $imageWidth, $thumbWidth)
          Severity: Minor
          Found in src/Http/Controllers/Controller.php - About 35 mins to fix

            Function boot has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function boot()
    {
        /*
         * Optional methods to load your package assets
         */
            Severity: Minor
            Found in src/LaravelSmartBlogServiceProvider.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language