Sign upLogin

davidlatwe/MontyDB

View on GitHub
Star
montydb/collection.py

Summary

Maintainability
D
2 days
Test Coverage

File collection.py has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import warnings
from copy import deepcopy

from .base import (
    BaseObject,
Severity: Minor
Found in montydb/collection.py - About 5 hrs to fix

    MontyCollection has 28 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    class MontyCollection(BaseObject):
    def __init__(
        self,
        database,
        name,
    Severity: Minor
    Found in montydb/collection.py - About 3 hrs to fix

      Function distinct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def distinct(self, key, filter=None, **kwargs):
        """ """
        if not isinstance(key, string_types):
            raise TypeError(
                "key must be an instance of %s" % (string_types.__name__,)
      Severity: Minor
      Found in montydb/collection.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _internal_upsert has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def _internal_upsert(self, query_spec, updator, raw_result):
        """Internal document upsert"""
        doc_cls = self._database.codec_options.document_class

        def _remove_dollar_key(doc):
      Severity: Minor
      Found in montydb/collection.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in montydb/collection.py - About 1 hr to fix

        Function update_many has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_many(
        self,
        filter,
        update,
        upsert=False,
        Severity: Minor
        Found in montydb/collection.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function replace_one has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def replace_one(
        self,
        filter,
        replacement,
        upsert=False,
        Severity: Minor
        Found in montydb/collection.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _internal_scan_query has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def _internal_scan_query(self, query_spec):
        """An internal document generator for update"""
        queryfilter = QueryFilter(query_spec)
        documents = self._storage.query(MontyCursor(self), 0)
        first_matched = None
        Severity: Minor
        Found in montydb/collection.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update_one has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def update_one(
        Severity: Major
        Found in montydb/collection.py - About 50 mins to fix

          Function update_many has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def update_many(
          Severity: Major
          Found in montydb/collection.py - About 50 mins to fix

            Function replace_one has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def replace_one(
            Severity: Minor
            Found in montydb/collection.py - About 45 mins to fix

              Function insert_many has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def insert_many(
              Severity: Minor
              Found in montydb/collection.py - About 35 mins to fix

                Function update_one has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def update_one(
        self,
        filter,
        update,
        upsert=False,
                Severity: Minor
                Found in montydb/collection.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function insert_many has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def insert_many(
        self, documents, ordered=True, bypass_document_validation=False, *args, **kwargs
    ):
        """ """
        if not isinstance(documents, abc.Iterable) or not documents:
                Severity: Minor
                Found in montydb/collection.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def __eq__(self, other):
        if isinstance(other, self.__class__):
            return self._database == other.database and self._name == other.name
        return NotImplemented
                Severity: Major
                Found in montydb/collection.py and 1 other location - About 1 hr to fix
                montydb/database.py on lines 20..24

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status