Sign upLogin

davidmigloz/go-bees

View on GitHub
Star
app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryPresenter.java

Summary

Maintainability
A
1 hr
Test Coverage

Method saveApiary has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void saveApiary(long apiaryId, String name, Double latitude, Double longitude,
                            String notes) {
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryPresenter.java - About 35 mins to fix

    Method save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void save(String name, String latitude, String longitude, String notes) {
        Double lat = null;
        Double lon = null;
        // Check name not empty
    Severity: Minor
    Found in app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryPresenter.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status