Sign upLogin

davidmigloz/go-bees

View on GitHub
Star
app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryPresenter.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method loadData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void loadData(boolean forceUpdate) {
        // Force update the first time
        boolean update = forceUpdate || firstLoad;
        firstLoad = false;
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryPresenter.java - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Override
    public void deleteHive(@NonNull Hive hive) {
        // Show progress indicator
        apiaryHivesView.setLoadingIndicator(true);
        // Delete hive
    Severity: Major
    Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryPresenter.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesPresenter.java on lines 115..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                @Override
            public void onDataNotAvailable() {
                // The view may not be able to handle UI updates anymore
                if (!apiaryHivesView.isActive() && !apiaryInfoView.isActive()) {
                    return;
    Severity: Minor
    Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryPresenter.java and 1 other location - About 35 mins to fix
    app/src/main/java/com/davidmiguel/gobees/hive/HivePresenter.java on lines 127..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status