Sign upLogin

davidmigloz/go-bees

View on GitHub
Star
app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java

Summary

Maintainability
C
7 hrs
Test Coverage

MonitoringFragment has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public class MonitoringFragment extends Fragment implements MonitoringContract.View,
        BackClickHelperFragment {

    public static final String ARGUMENT_APIARY_ID = "APIARY_ID";
    public static final String ARGUMENT_HIVE_ID = "HIVE_ID";
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java - About 3 hrs to fix

    Method onCreateView has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Nullable
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View root = inflater.inflate(R.layout.monitoring_frag, container, false);
    Severity: Major
    Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          @Override
                    public void onRecordingTooShort() {
                        // Finish activity with error
                        Intent intent = new Intent();
                        intent.putExtra(HiveRecordingsFragment.ARGUMENT_MONITORING_ERROR,
      Severity: Minor
      Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java and 1 other location - About 35 mins to fix
      app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java on lines 160..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          @Override
                    public void onFailure() {
                        // Finish activity with error
                        Intent intent = new Intent();
                        intent.putExtra(HiveRecordingsFragment.ARGUMENT_MONITORING_ERROR,
      Severity: Minor
      Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java and 1 other location - About 35 mins to fix
      app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java on lines 142..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Member name 'mService' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
      Open

          private MonitoringService mService;
      Severity: Minor
      Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java by checkstyle

      Checks that instance variable names conform to a specified pattern.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Member name 'mConnection' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
      Open

          private ServiceConnection mConnection;
      Severity: Minor
      Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringFragment.java by checkstyle

      Checks that instance variable names conform to a specified pattern.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status