Sign upLogin

davidmigloz/go-bees

View on GitHub
Star
app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java

Summary

Maintainability
D
2 days
Test Coverage

File RecordingFragment.java has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * GoBees
 * Copyright (c) 2016 - 2017 David Miguel Lozano
 *
 * This program is free software: you can redistribute it and/or modify
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 4 hrs to fix

    RecordingFragment has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class RecordingFragment extends Fragment implements RecordingContract.View {

    public static final String ARGUMENT_APIARY_ID = "APIARY_ID";
    public static final String ARGUMENT_HIVE_ID = "HIVE_ID";
    public static final String ARGUMENT_START_DATE = "START_DATE";
    Severity: Minor
    Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 2 hrs to fix

      Method setupBeesChart has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void setupBeesChart(List<Record> recordsList) {
        // Setup data
        referenceTimestamp = recordsList.get(0).getTimestamp().getTime() / 1000;
        Record[] records = recordsList.toArray(new Record[recordsList.size()]);
        List<Entry> entries = new ArrayList<>();
      Severity: Major
      Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 2 hrs to fix

        Method configureWeatherChart has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private LineDataSet configureWeatherChart(
            LineChart chart, int chartName, int colorLineTempChart, int colorFillTempChart,
            List<Entry> entries, IAxisValueFormatter formatter, double minVal, double maxVal) {
        LineDataSet lineDataSet = new LineDataSet(entries, getString(chartName));
        lineDataSet.setMode(LineDataSet.Mode.HORIZONTAL_BEZIER);
        Severity: Minor
        Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 1 hr to fix

          Method onCreateView has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Nullable
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View root = inflater.inflate(R.layout.recording_frag, container, false);
          Severity: Minor
          Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 1 hr to fix

            Method configureWeatherChart has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        LineChart chart, int chartName, int colorLineTempChart, int colorFillTempChart,
            List<Entry> entries, IAxisValueFormatter formatter, double minVal, double maxVal) {
            Severity: Major
            Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 1 hr to fix

              Method setupTempChart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void setupTempChart(List<MeteoRecord> meteo) {
        // Setup data
        List<Entry> entries = new ArrayList<>();
        // Add as first entry a copy of the first temperature record
        // First relative timestamp is 0
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private void setupRainChart(List<MeteoRecord> meteo) {
        // Setup data
        List<Entry> entries = new ArrayList<>();
        // Add as first entry a copy of the first rain record
        // First relative timestamp is 0
              Severity: Major
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java and 1 other location - About 3 hrs to fix
              app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java on lines 400..427

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private void setupWindChart(List<MeteoRecord> meteo) {
        // Setup data
        List<Entry> entries = new ArrayList<>();
        // Add as first entry a copy of the first wind record
        // First relative timestamp is 0
              Severity: Major
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java and 1 other location - About 3 hrs to fix
              app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java on lines 365..392

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Local variable name 'xAxis' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
              Open

                      XAxis xAxis = chart.getXAxis();
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java by checkstyle

              Checks that local, non-final variable names conform to a specified pattern.A catch parameter is considered to be a local variable.

              This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

              Local variable name 'xAxisFormatter' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
              Open

                      IAxisValueFormatter xAxisFormatter = new HourAxisValueFormatter(referenceTimestamp);
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java by checkstyle

              Checks that local, non-final variable names conform to a specified pattern.A catch parameter is considered to be a local variable.

              This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

              '?' should be on a new line.
              Open

                              GoBeesPreferences.isMetric(getContext()) ?
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java by checkstyle

              Checks the policy on how to wrap lines on operators.

              This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

              Local variable name 'xAxis' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
              Open

                      XAxis xAxis = beesChart.getXAxis();
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java by checkstyle

              Checks that local, non-final variable names conform to a specified pattern.A catch parameter is considered to be a local variable.

              This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

              There are no issues that match your filters.

              Category
              Status