Sign upLogin

davidmigloz/go-bees

View on GitHub
Star

Showing 387 of 387 total issues

Method deleteHiveTest has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void deleteHiveTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java - About 2 hrs to fix

    Method setupBeesChart has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void setupBeesChart(List<Record> recordsList) {
        // Setup data
        referenceTimestamp = recordsList.get(0).getTimestamp().getTime() / 1000;
        Record[] records = recordsList.toArray(new Record[recordsList.size()]);
        List<Entry> entries = new ArrayList<>();
    Severity: Major
    Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (addEditHiveFragment == null) {
            addEditHiveFragment = AddEditHiveFragment.newInstance();
            if (getIntent().hasExtra(AddEditHiveFragment.ARGUMENT_EDIT_HIVE_ID)) {
                // If edit -> set edit title
                if (actionBar != null) {
      Severity: Major
      Found in app/src/main/java/com/davidmiguel/gobees/addedithive/AddEditHiveActivity.java and 1 other location - About 1 hr to fix
      app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryActivity.java on lines 54..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (addEditApiaryFragment == null) {
            addEditApiaryFragment = AddEditApiaryFragment.newInstance();
            if (getIntent().hasExtra(AddEditApiaryFragment.ARGUMENT_EDIT_APIARY_ID)) {
                // If edit -> set edit title
                if (actionBar != null) {
      Severity: Major
      Found in app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryActivity.java and 1 other location - About 1 hr to fix
      app/src/main/java/com/davidmiguel/gobees/addedithive/AddEditHiveActivity.java on lines 61..79

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 126.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method settingsTest has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Test
    public void settingsTest() {
        ViewInteraction appCompatImageButton = onView(
                allOf(withContentDescription("Navigate up"),
                        withParent(withId(R.id.toolbar)),
      Severity: Minor
      Found in app/src/androidTest/java/com/davidmiguel/gobees/settings/SettingsTest.java - About 1 hr to fix

        Method checkLocationPermission has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    public boolean checkLocationPermission() {
        // Check location permission
        if (PermissionUtils.isGranted(getActivity(), PermissionEnum.ACCESS_FINE_LOCATION)) {
            return true;
        Severity: Minor
        Found in app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryFragment.java - About 1 hr to fix

          Method listApiariesTest has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Test
    public void listApiariesTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
          Severity: Minor
          Found in app/src/androidTest/java/com/davidmiguel/gobees/apiaries/ListApiariesTest.java - About 1 hr to fix

            Method aboutTest has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Test
    public void aboutTest() {
        ViewInteraction appCompatImageButton = onView(
                allOf(withContentDescription("Navigate up"),
                        withParent(withId(R.id.toolbar)),
            Severity: Minor
            Found in app/src/androidTest/java/com/davidmiguel/gobees/about/AboutTest.java - About 1 hr to fix

              Method showInfo has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @SuppressWarnings("ConstantConditions")
    @Override
    public void showInfo(Apiary apiary, Date lastRevisionDate) {
        // GENERAL INFO
        // Location
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryInfoFragment.java - About 1 hr to fix

                Method checkCameraPermission has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
    public boolean checkCameraPermission() {
        // Check camera permission
        if (PermissionUtils.isGranted(getActivity(), PermissionEnum.CAMERA)) {
            return true;
                Severity: Minor
                Found in app/src/main/java/com/davidmiguel/gobees/hive/HiveRecordingsFragment.java - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  /*
 * GoBees
 * Copyright (c) 2016 - 2017 David Miguel Lozano
 *
 * This program is free software: you can redistribute it and/or modify
                  Severity: Major
                  Found in app/src/main/java/com/davidmiguel/gobees/help/HelpActivity.java and 1 other location - About 1 hr to fix
                  app/src/main/java/com/davidmiguel/gobees/about/AboutActivity.java on lines 1..59

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  /*
 * GoBees
 * Copyright (c) 2016 - 2017 David Miguel Lozano
 *
 * This program is free software: you can redistribute it and/or modify
                  Severity: Major
                  Found in app/src/main/java/com/davidmiguel/gobees/about/AboutActivity.java and 1 other location - About 1 hr to fix
                  app/src/main/java/com/davidmiguel/gobees/help/HelpActivity.java on lines 1..59

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private Location getRandomNearLocation(double latitude, double longitude) {
        Random random = new Random();
        double lat = BigDecimal.valueOf(latitude + random.nextInt(100) / 100d)
                .setScale(7, RoundingMode.HALF_UP).doubleValue();
        double lon = BigDecimal.valueOf(longitude + random.nextInt(100) / 100d)
                  Severity: Major
                  Found in app/src/test/java/com/davidmiguel/gobees/data/model/mothers/ApiaryMother.java and 1 other location - About 1 hr to fix
                  app/src/main/java/com/davidmiguel/gobees/data/source/local/DataGenerator.java on lines 263..273

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 111.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private Location getRandomNearLocation(double latitude, double longitude) {
        Random random = new Random();
        double lat = BigDecimal.valueOf(latitude + random.nextInt(100) / 100d)
                .setScale(7, RoundingMode.HALF_UP).doubleValue();
        double lon = BigDecimal.valueOf(longitude + random.nextInt(100) / 100d)
                  Severity: Major
                  Found in app/src/main/java/com/davidmiguel/gobees/data/source/local/DataGenerator.java and 1 other location - About 1 hr to fix
                  app/src/test/java/com/davidmiguel/gobees/data/model/mothers/ApiaryMother.java on lines 139..149

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 111.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method onStartCommand has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @Override
    public int onStartCommand(Intent intent, int flags, int startId) {
        super.onStartCommand(intent, flags, startId);

        // START action
                  Severity: Minor
                  Found in app/src/main/java/com/davidmiguel/gobees/monitoring/MonitoringService.java - About 1 hr to fix

                    Method deleteApiaryTest has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        @Test
    public void deleteApiaryTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
                    Severity: Minor
                    Found in app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java - About 1 hr to fix

                      Method addHiveTest has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          @Test
    public void addHiveTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
                      Severity: Minor
                      Found in app/src/androidTest/java/com/davidmiguel/gobees/apiary/AddHiveTest.java - About 1 hr to fix

                        Method checkCurrentWeather has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private void checkCurrentWeather(boolean forceUpdate, List<Apiary> apiaries) {
        List<Apiary> apiariesToUpdate = new ArrayList<>();
        Date now = new Date();
        // Check dates
        for (Apiary apiary : apiaries) {
                        Severity: Minor
                        Found in app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesPresenter.java - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method editApiaryTest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            @Test
    public void editApiaryTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
                        Severity: Minor
                        Found in app/src/androidTest/java/com/davidmiguel/gobees/apiaries/EditApiaryTest.java - About 1 hr to fix

                          Method viewApiaryTest has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              @Test
    public void viewApiaryTest() {
        ViewInteraction floatingActionButton = onView(
                allOf(withId(R.id.fab_add_apiary),
                        withParent(withId(R.id.coordinatorLayout)),
                          Severity: Minor
                          Found in app/src/androidTest/java/com/davidmiguel/gobees/apiaries/ViewApiaryTest.java - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language