Sign upLogin

davidmigloz/go-bees

View on GitHub
Star

Showing 387 of 387 total issues

Method onCreate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.recording_act);
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingActivity.java - About 1 hr to fix

    Method onCreateView has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Nullable
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View root = inflater.inflate(R.layout.about_frag, container, false);
    Severity: Minor
    Found in app/src/main/java/com/davidmiguel/gobees/about/AboutFragment.java - About 1 hr to fix

      Method checkCurrentWeather has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void checkCurrentWeather(boolean forceUpdate, List<Apiary> apiaries) {
        List<Apiary> apiariesToUpdate = new ArrayList<>();
        Date now = new Date();
        // Check dates
        for (Apiary apiary : apiaries) {
      Severity: Minor
      Found in app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesPresenter.java - About 1 hr to fix

        Method setupDrawerContent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void setupDrawerContent(NavigationView navigationView) {
        navigationView.setNavigationItemSelectedListener(
                new NavigationView.OnNavigationItemSelectedListener() {
                    @Override
                    public boolean onNavigationItemSelected(@NonNull MenuItem menuItem) {
        Severity: Minor
        Found in app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesActivity.java - About 1 hr to fix

          Method updateApiariesCurrentWeather has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              @SuppressWarnings("ConstantConditions")
    @Override
    public void updateApiariesCurrentWeather(final List<Apiary> apiariesToUpdate,
                                             @NonNull final TaskCallback callback) {
        checkNotNull(callback);
          Severity: Minor
          Found in app/src/main/java/com/davidmiguel/gobees/data/source/repository/GoBeesRepository.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method loadData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
    public void loadData(final boolean forceUpdate) {
        // Force update the first time
        final boolean update = forceUpdate || firstLoad;
        firstLoad = false;
          Severity: Minor
          Found in app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesPresenter.java - About 1 hr to fix

            Method onCreateView has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View root = inflater.inflate(R.layout.apiary_info_frag, container, false);
            Severity: Minor
            Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryInfoFragment.java - About 1 hr to fix

              Method deleteRecording has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @Override
    public void deleteRecording(long hiveId, @NonNull Recording recording,
                                @NonNull TaskCallback callback) {
        try {
            // Get hive
              Severity: Minor
              Found in app/src/main/java/com/davidmiguel/gobees/data/source/local/GoBeesLocalDataSource.java - About 1 hr to fix

                Method deleteApiary has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
    public void deleteApiary(long apiaryId, @NonNull TaskCallback callback) {
        try {
            // Get apiary
            final Apiary apiary = realm.where(Apiary.class).equalTo(ID, apiaryId).findFirst();
                Severity: Minor
                Found in app/src/main/java/com/davidmiguel/gobees/data/source/local/GoBeesLocalDataSource.java - About 1 hr to fix

                  Method onCreate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.addeditapiary_act);
                  Severity: Minor
                  Found in app/src/main/java/com/davidmiguel/gobees/addeditapiary/AddEditApiaryActivity.java - About 1 hr to fix

                    Method formatWind has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static String formatWind(Context context, double windSpeed, double deg) {
        int windFormat = R.string.format_wind_kmh;

        double value;
        if (!GoBeesPreferences.isMetric(context)) {
                    Severity: Minor
                    Found in app/src/main/java/com/davidmiguel/gobees/utils/WeatherUtils.java - About 1 hr to fix

                      Method saveRecords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          @Override
    public void saveRecords(final long hiveId, @NonNull final List<Record> records,
                            @NonNull SaveRecordingCallback callback) {
        if (records.size() < 5) {
            // Recording too short
                      Severity: Minor
                      Found in app/src/main/java/com/davidmiguel/gobees/data/source/local/GoBeesLocalDataSource.java - About 1 hr to fix

                        Method getResponseFromHttpUrl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            static String getResponseFromHttpUrl(URL url) throws IOException {
        if (url == null) {
            return null;
        }
        // Make the call to the api
                        Severity: Minor
                        Found in app/src/main/java/com/davidmiguel/gobees/data/source/network/NetworkUtils.java - About 1 hr to fix

                          Method meteoRecordTest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              @Test
    public void meteoRecordTest() {
        MeteoRecord meteoRecord = new MeteoRecord();
        // Id
        meteoRecord.setId(1);
                          Severity: Minor
                          Found in app/src/test/java/com/davidmiguel/gobees/data/model/MeteoRecordTest.java - About 1 hr to fix

                            Method configureWeatherChart has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                        LineChart chart, int chartName, int colorLineTempChart, int colorFillTempChart,
            List<Entry> entries, IAxisValueFormatter formatter, double minVal, double maxVal) {
                            Severity: Major
                            Found in app/src/main/java/com/davidmiguel/gobees/recording/RecordingFragment.java - About 1 hr to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  @Test
    public void getFormattedValue() throws Exception {
        WindValueFormatter windValueFormatter = new WindValueFormatter(WindValueFormatter.Unit.MS);
        String res = windValueFormatter.getFormattedValue(10, null);
        assertEquals("10m/s", res);
                              Severity: Minor
                              Found in app/src/test/java/com/davidmiguel/gobees/utils/WindValueFormatterTest.java and 1 other location - About 55 mins to fix
                              app/src/test/java/com/davidmiguel/gobees/utils/TempValueFormatterTest.java on lines 34..42

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  @Test
    public void getFormattedValueCelsius() throws Exception {
        TempValueFormatter tempValueFormatter =
                new TempValueFormatter(TempValueFormatter.Unit.CELSIUS);
        String res = tempValueFormatter.getFormattedValue(10, null);
                              Severity: Minor
                              Found in app/src/test/java/com/davidmiguel/gobees/utils/TempValueFormatterTest.java and 1 other location - About 55 mins to fix
                              app/src/test/java/com/davidmiguel/gobees/utils/WindValueFormatterTest.java on lines 29..36

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Method showInfo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  @SuppressWarnings("ConstantConditions")
    @Override
    public void showInfo(Apiary apiary, Date lastRevisionDate) {
        // GENERAL INFO
        // Location
                              Severity: Minor
                              Found in app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryInfoFragment.java - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  @Override
    public void showDataDeletedMsg() {
        hideLoading();
        // Show msg
        Toast.makeText(getActivity(), getString(R.string.all_data_deleted_msg),
                              Severity: Minor
                              Found in app/src/main/java/com/davidmiguel/gobees/settings/SettingsFragment.java and 1 other location - About 55 mins to fix
                              app/src/main/java/com/davidmiguel/gobees/settings/SettingsFragment.java on lines 93..105

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 65.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  @Override
    public void showDataGeneratedMsg() {
        hideLoading();
        // Show msg
        Toast.makeText(getActivity(), getString(R.string.sample_data_generated_msg),
                              Severity: Minor
                              Found in app/src/main/java/com/davidmiguel/gobees/settings/SettingsFragment.java and 1 other location - About 55 mins to fix
                              app/src/main/java/com/davidmiguel/gobees/settings/SettingsFragment.java on lines 107..117

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 65.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language