Sign upLogin

davispeixoto/Force.com-Toolkit-for-PHP

View on GitHub
Star

Showing 30 of 30 total issues

File SforceBaseClient.php has 673 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Davispeixoto\ForceDotComToolkitForPhp;

    /*
     * Copyright (c) 2007, salesforce.com, inc.
     * All rights reserved.
Severity: Major
Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 1 day to fix

    Function __construct has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($response = null)
    {
        if (!isset($response) && !$response) {
            return;
        }
    Severity: Minor
    Found in src/Davispeixoto/ForceDotComToolkitForPhp/SObject.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function xml2array has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
    Open

        public function xml2array($contents, $get_attributes = 1)
    {
        if (!$contents) {
            return array();
        }
    Severity: Minor
    Found in src/Davispeixoto/ForceDotComToolkitForPhp/SObject.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    SforceBaseClient has 63 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SforceBaseClient
{
    protected $sforce;
    protected $sessionId;
    protected $location;
    Severity: Major
    Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 1 day to fix

      Function setHeaders has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setHeaders($call = null)
    {
        $this->sforce->__setSoapHeaders(null);

        $header_array = array(
      Severity: Minor
      Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setHeaders has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function setHeaders($call = null)
    {
        $this->sforce->__setSoapHeaders(null);

        $header_array = array(
      Severity: Major
      Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 4 hrs to fix

        Method xml2array has 87 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function xml2array($contents, $get_attributes = 1)
    {
        if (!$contents) {
            return array();
        }
        Severity: Major
        Found in src/Davispeixoto/ForceDotComToolkitForPhp/SObject.php - About 3 hrs to fix

          SforceCustomField has 28 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SforceCustomField
{
    public function setCaseSensitive($caseSensitive)
    {
        $this->caseSensitive = $caseSensitive;
          Severity: Minor
          Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceCustomField.php - About 3 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function sendMassEmail($request)
    {
        if (is_array($request)) {
            $messages = array();
            foreach ($request as $r) {
            Severity: Major
            Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 3 hrs to fix
            src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 584..601

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function sendSingleEmail($request)
    {
        if (is_array($request)) {
            $messages = array();
            foreach ($request as $r) {
            Severity: Major
            Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 3 hrs to fix
            src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 603..620

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($sObjects as $sObject) {
            // FIX for fieldsToNull issue - allow array in fieldsToNull (STEP #1)
            $xmlStr = '';
            if (isset($sObject->fieldsToNull) && is_array($sObject->fieldsToNull)) {
                foreach ($sObject->fieldsToNull as $fieldToNull) {
            Severity: Major
            Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceEnterpriseClient.php and 1 other location - About 3 hrs to fix
            src/Davispeixoto/ForceDotComToolkitForPhp/SforceEnterpriseClient.php on lines 131..147

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 143.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($sObjects as $sObject) {
            // FIX for fieldsToNull issue - allow array in fieldsToNull (STEP #1)
            $xmlStr = '';
            if (isset($sObject->fieldsToNull) && is_array($sObject->fieldsToNull)) {
                foreach ($sObject->fieldsToNull as $fieldToNull) {
            Severity: Major
            Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceEnterpriseClient.php and 1 other location - About 3 hrs to fix
            src/Davispeixoto/ForceDotComToolkitForPhp/SforceEnterpriseClient.php on lines 93..109

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 143.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method __construct has 70 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct($response = null)
    {
        if (!isset($response) && !$response) {
            return;
        }
            Severity: Major
            Found in src/Davispeixoto/ForceDotComToolkitForPhp/SObject.php - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (is_array($request)) {
            $messages = array();
            foreach ($request as $r) {
                $email = new \SoapVar($r, SOAP_ENC_OBJECT, 'MassEmailMessage', $this->namespace);
                array_push($messages, $email);
              Severity: Major
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforcePartnerClient.php and 1 other location - About 2 hrs to fix
              src/Davispeixoto/ForceDotComToolkitForPhp/SforcePartnerClient.php on lines 93..106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (is_array($request)) {
            $messages = array();
            foreach ($request as $r) {
                $email = new \SoapVar($r, SOAP_ENC_OBJECT, 'SingleEmailMessage', $this->namespace);
                array_push($messages, $email);
              Severity: Major
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforcePartnerClient.php and 1 other location - About 2 hrs to fix
              src/Davispeixoto/ForceDotComToolkitForPhp/SforcePartnerClient.php on lines 116..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function processSubmitRequest($processRequestArray)
    {
        if (is_array($processRequestArray)) {
            foreach ($processRequestArray as &$process) {
                $process = new SoapVar($process, SOAP_ENC_OBJECT, 'ProcessSubmitRequest', $this->namespace);
              Severity: Major
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 2 hrs to fix
              src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 736..751

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function processWorkitemRequest($processRequestArray)
    {
        if (is_array($processRequestArray)) {
            foreach ($processRequestArray as &$process) {
                $process = new SoapVar($process, SOAP_ENC_OBJECT, 'ProcessWorkitemRequest', $this->namespace);
              Severity: Major
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 2 hrs to fix
              src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 713..728

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 125.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __construct($response)
    {
        if ($response instanceof SforceSearchResult) {
            $this->searchRecords = $response->searchRecords;
        } else {
              Severity: Minor
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceSearchResult.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __construct($response)
    {
        $this->queryLocator = $response->queryLocator;
        $this->done = $response->done;
        $this->size = $response->size;
              Severity: Minor
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/QueryResult.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($wsdl, $loginResult, $sforceConn)
    {
        $soapClientArray = null;

        $phpversion = substr(PHP_VERSION, 0, strpos(PHP_VERSION, '-'));
              Severity: Minor
              Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceMetadataClient.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language