Sign upLogin

dawn/dawn

View on GitHub
Star
app/controllers/apps_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class AppsController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class AppsController < ApiController
  actions = [:index, :create]
  before_action :find_app, except: actions
  before_action :verify_app_owner, except: actions
Severity: Minor
Found in app/controllers/apps_controller.rb - About 2 hrs to fix

    Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    unless params[:command].present?
      response = { id: "run.command.invalid",
                   message: "invalid command given (#{params[:command]})" }
      render json: response, status: 400
    Severity: Minor
    Found in app/controllers/apps_controller.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        private def find_app
    app = App.where(id: params[:id]).first
    app = App.where(name: params[:id]).first unless app
    if app
      @app = app
      Severity: Minor
      Found in app/controllers/apps_controller.rb and 1 other location - About 55 mins to fix
      app/controllers/domains_controller.rb on lines 21..30

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            @domain = @app.domains.create(app: @app, url: url)
      if @domain.save
        render 'domains/domain', status: 200
      else
        response = { id: "domain.save.fail",
      Severity: Minor
      Found in app/controllers/apps_controller.rb and 1 other location - About 35 mins to fix
      app/controllers/apps_controller.rb on lines 126..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            @drain = @app.drains.create(app: @app, url: url)
      if @drain.save
        render 'drains/drain', status: 200
      else
        response = { id: "drain.save.fail",
      Severity: Minor
      Found in app/controllers/apps_controller.rb and 1 other location - About 35 mins to fix
      app/controllers/apps_controller.rb on lines 143..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status