Sign upLogin

dblock/dzt

View on GitHub
Star

Showing 3 of 3 total issues

Method slice! has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def slice!(&_block)
      fail "Output #{@destination} already exists!" if ! @overwrite && @storage.exists?

      image = @tile_source.dup
      orig_width = image.columns
Severity: Minor
Found in lib/dzt/tiler.rb - About 1 hr to fix

    Method slice! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def slice!(&_block)
      fail "Output #{@destination} already exists!" if ! @overwrite && @storage.exists?

      image = @tile_source.dup
      orig_width = image.columns
    Severity: Minor
    Found in lib/dzt/tiler.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method save_cropped_image has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def save_cropped_image(src, dest, x, y, width, height, quality = 75)
    Severity: Major
    Found in lib/dzt/tiler.rb - About 50 mins to fix
      Severity
      Category
      Status
      Source
      Language