Sign upLogin

dblock/heroku-commander

View on GitHub
Star

Showing 14 of 14 total issues

Method tail! has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

      def tail!(options = {}, &block)
        lines = []
        tail_cmdline = [ "heroku", "logs", "-p #{@pid}", "--tail", @app ? "--app #{@app}" : nil ].compact.join(" ")
        previous_line = nil # delay by 1 to avoid rc=status lines
        process_completed = false
Severity: Minor
Found in lib/heroku/runner.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

      def run(cmd, options = {}, &block)
        lines = []
        running_pid = nil
        logger = options[:logger]
        logger.debug "Running: #{cmd}" if logger
Severity: Minor
Found in lib/heroku/executor.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tail! has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def tail!(options = {}, &block)
        lines = []
        tail_cmdline = [ "heroku", "logs", "-p #{@pid}", "--tail", @app ? "--app #{@app}" : nil ].compact.join(" ")
        previous_line = nil # delay by 1 to avoid rc=status lines
        process_completed = false
Severity: Major
Found in lib/heroku/runner.rb - About 2 hrs to fix

    Method run has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run(cmd, options = {}, &block)
        lines = []
        running_pid = nil
        logger = options[:logger]
        logger.debug "Running: #{cmd}" if logger
    Severity: Minor
    Found in lib/heroku/executor.rb - About 1 hr to fix

      Method processes has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def processes(&block)
      processes = []
      cmdline = [ "heroku", "ps", @app ? "--app #{@app}" : nil ].compact.join(" ")
      Heroku::Executor.run cmdline, { :logger => logger } do |line|
        next if ! line || line[0] == '=' || line.length == 0
      Severity: Minor
      Found in lib/heroku/commander.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method terminate_process! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def terminate_process!(pid, timeout)
          if timeout
            # Delay terminating of the process, usually to let the output flush.
            Thread.new(pid, timeout) do |pid, timeout|
              begin
      Severity: Minor
      Found in lib/heroku/executor.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run_detached! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def run_detached!(options = {}, &block)
        raise Heroku::Commander::Errors::AlreadyRunningError.new({ :pid => @pid }) if running?
        @running = true
        @pid = nil
        @tail = nil
      Severity: Minor
      Found in lib/heroku/runner.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_from has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def read_from(r, pid, options, lines, &block)
      Severity: Minor
      Found in lib/heroku/executor.rb - About 35 mins to fix

        Method read_from has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def read_from(r, pid, options, lines, &block)
          logger = options[:logger]
          while ! r.eof do
            line = r.readline
            line.strip! if line
        Severity: Minor
        Found in lib/heroku/executor.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run_attached! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def run_attached!(options = {}, &block)
        @pid = nil
        previous_line = nil # delay by 1 to avoid rc=status line
        lines_until_pid = 0
        lines = Heroku::Executor.run cmdline, { :logger => logger } do |line|
        Severity: Minor
        Found in lib/heroku/runner.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_exit_status! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def check_exit_status!(lines)
        status = (lines.size > 0) && (match = lines[-1].match(/^rc=(\d+)$/)) ? match[1] : nil
        lines.pop if status
        raise Heroku::Commander::Errors::CommandError.new({
          :cmd => @command,
        Severity: Minor
        Found in lib/heroku/runner.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cmdline has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def cmdline(options = {})
        [
          "heroku", options[:detached] ? "run:detached" : "run",
          @size ? "--size=#{@size}" : nil,
          "\"(#{command} 2>&1 ; echo rc=\\$?)\"",
        Severity: Minor
        Found in lib/heroku/runner.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def initialize(options = {})
      @app = options[:app]
      @logger = options[:logger]
      @pid = options[:pid]
      @status = options[:status]
        Severity: Minor
        Found in lib/heroku/process.rb and 1 other location - About 20 mins to fix
        lib/heroku/runner.rb on lines 7..12

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def initialize(options = {})
      @app = options[:app]
      @logger = options[:logger]
      @command = options[:command]
      @size = options[:size]
        Severity: Minor
        Found in lib/heroku/runner.rb and 1 other location - About 20 mins to fix
        lib/heroku/process.rb on lines 6..11

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language